[vtk-developers] vtkSleep bug?

[David Partyka]

Hi Sean,

I just looked over your code and appears reasonable.
Considering you already have commit access, you have already been granted a
level of trust. Run a ctest -D Experimental and see how this affects any
tests, if all is well then merge it. I'll back you up ;-)

On Fri, Jan 28, 2011 at 11:16 AM, Sean McBride <sean at rogue-research.com>wrote:

> On Thu, 27 Jan 2011 13:24:01 -0700, David Gobbi said:
>
> >I don't know who was responsible for the copy/paste, but the
> >original code from vtkVideoSource is mine. In my own defence,
> >when I wrote the code, OS X didn't exist.
> >
> >Since you volunteered, there is probably a suitable kwsys function
> >that could be called instead, and if not, you can petition Kitware to
> >add one ;)
>
> I pushed a branch named "vtkSleep-fixes" to the stage.  It fixes the
> issue on OS X, fixes a warning, and makes the triplications identical.
>
> I leave moving it to someone that knows VTK's architecture better than me.
>
> Which reminds me.... wrt to the git workflow... what do I do now that
> I've pushed to the stage?  Do I wait for a reviewer then merge to
> master?  Or does the reviewer to that?  Or do I just trust myself and
> merge now?
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20110128/bf55ef92/attachment.html>