<div>Hi Sean,</div><div><br></div><div>I just looked over your code and appears reasonable.</div>Considering you already have commit access, you have already been granted a level of trust. Run a ctest -D Experimental and see how this affects any tests, if all is well then merge it. I'll back you up ;-)<div>
<br><div class="gmail_quote">On Fri, Jan 28, 2011 at 11:16 AM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Thu, 27 Jan 2011 13:24:01 -0700, David Gobbi said:<br>
<br>
>I don't know who was responsible for the copy/paste, but the<br>
>original code from vtkVideoSource is mine. In my own defence,<br>
>when I wrote the code, OS X didn't exist.<br>
><br>
>Since you volunteered, there is probably a suitable kwsys function<br>
>that could be called instead, and if not, you can petition Kitware to<br>
>add one ;)<br>
<br>
</div>I pushed a branch named "vtkSleep-fixes" to the stage. It fixes the<br>
issue on OS X, fixes a warning, and makes the triplications identical.<br>
<br>
I leave moving it to someone that knows VTK's architecture better than me.<br>
<br>
Which reminds me.... wrt to the git workflow... what do I do now that<br>
I've pushed to the stage? Do I wait for a reviewer then merge to<br>
master? Or does the reviewer to that? Or do I just trust myself and<br>
merge now?<br>
<br>
Cheers,<br>
<font color="#888888"><br>
--<br>
</font><div><div></div><div class="h5">____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br></div>