[vtk-developers] patch for vtkInteractorStyle.cxx

[Chris Kruszynski]

The automated tests give the same results with and without the patch.

Regards,
Chris

On 07-08-08 17:05, David Cole wrote:
> You could easily run two experimental dashboards: one with your change 
> and one without your change...
> (just run "ctest -D Experimental" from your VTK build tree)
>
> At least that would verify that none of the automated test results are 
> different before and after your patch.
>
> If you do that, and there are no test result differences, and nobody 
> else comes up with a reason not to apply it, I would be happy to 
> commit this change for you.
>
>
> Thanks,
> David Cole
> Kitware, Inc.
>
>
> 2008/8/7 Chris Kruszynski <Chris.Kruszynski at cwi.nl 
> <mailto:Chris.Kruszynski at cwi.nl>>
>
>     Perhaps nobody ever uses timers in vtk, but this is something that
>     has been bugging me for quite some time and I decided to fix it:
>     vtkInteractorStyle and it's subclasses ignore the TimerId of a
>     TimerEvent and will respond to any TimerEvent from the interactor
>     even if it's not for the timer that they had set.
>
>     If you set a second timer on the interactor, and the timer goes
>     off, vtkInteractorStyle will invoke OnTimer(). This is most
>     noticeable if you set a quick repeating timer, and set the
>     interactor style to trackball camera: if you press the left mouse
>     button in the render window, the interactor will start rotating
>     just like with the joystick camera style, while your mouse
>     movements have still the same effect corresponding to the
>     trackball camera style.
>
>     This is a one-liner, but I am not sure if it breaks anything
>     (probably doesn't?).
>
>
>     regards,
>
>     Chris
>
>     _______________________________________________
>     vtk-developers mailing list
>     vtk-developers at vtk.org <mailto:vtk-developers at vtk.org>
>     http://www.vtk.org/mailman/listinfo/vtk-developers
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20080813/ea885453/attachment.html>