View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011175ITKpublic2010-08-26 09:352010-09-21 21:33
ReporterHans Johnson 
Assigned ToHans Johnson 
PlatformOSOS Version
Product VersionITK-4-A2 
Target VersionFixed in VersionITK-4-A2 
Summary0011175: CMakeLists.txt key words to lower case
DescriptionThe next step in removing end-of-lines is to run through all the CMakeLists.txt files and clean them up.

I would like to propose that we also change all the key words to lower case. The primary reason for this is that all documentation for CMakeLists.txt now shows the key words as lower case. Even the printed “Mastering CMake v5” uses lower case. I’ve come across this several times in my class where students stumble over the fact that the documentation about Cmake does not match the implementation in ITK.

I have a script (a wrapper around a vim macro) written that can make these substituions reliably (Tested on the BRAINS tree, the Slicer3 tree, and the ITK tree without causing any errors).

TagsNo tags attached.
Resolution Date2010-09-16
Sprint Statusbacklog
Attached Files? file icon convert_cmake_to_lowercase.vim [^] (4,072 bytes) 2010-08-30 18:00
txt file icon HowToCreateTheCMakeCaseConversion.txt [^] (1,197 bytes) 2010-09-16 09:15 [Show Content]


Hans Johnson (developer)
2010-08-30 18:01

export TMP_DIR=/tmp/

for ff in $(cat ${FILESTOCONVERT}); do
   echo "PROCESSING $ff";
   vim -S ${TMP_DIR}/convert_cmake_to_lowercase.vim $ff;
Hans Johnson (developer)
2010-09-16 09:12

As part of this effort, the subdirs command should be changed to the recommended add_subdirectory command.
Hans Johnson (developer)
2010-09-21 21:33

Addressed in commit number c50b6de4431716461477d38c5a491c071b75bf3b

 Issue History
Date Modified Username Field Change
2010-08-26 09:35 Hans Johnson New Issue
2010-08-26 09:36 Hans Johnson Status new => assigned
2010-08-26 09:36 Hans Johnson Assigned To => Hans Johnson
2010-08-30 18:00 Hans Johnson File Added: convert_cmake_to_lowercase.vim
2010-08-30 18:01 Hans Johnson Note Added: 0022008
2010-08-30 18:02 Hans Johnson File Added: HowToCreateTheCMakeCaseConversion.txt
2010-09-16 09:12 Hans Johnson Note Added: 0022257
2010-09-16 09:14 Hans Johnson File Deleted: HowToCreateTheCMakeCaseConversion.txt
2010-09-16 09:15 Hans Johnson File Added: HowToCreateTheCMakeCaseConversion.txt
2010-09-21 21:33 Hans Johnson Resolution Date => 2010-09-16
2010-09-21 21:33 Hans Johnson Sprint Status => backlog
2010-09-21 21:33 Hans Johnson Note Added: 0022310
2010-09-21 21:33 Hans Johnson Status assigned => closed
2010-09-21 21:33 Hans Johnson Resolution open => fixed
2010-09-21 21:33 Hans Johnson Fixed in Version => ITK-4-A2

Copyright © 2000 - 2018 MantisBT Team