MantisBT - ITK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011175ITKpublic2010-08-26 09:352010-09-21 21:33
ReporterHans Johnson 
Assigned ToHans Johnson 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionITK-4-A2 
Target VersionFixed in VersionITK-4-A2 
Resolution Date2010-09-16
Sprint
Sprint Statusbacklog
Summary0011175: CMakeLists.txt key words to lower case
DescriptionThe next step in removing end-of-lines is to run through all the CMakeLists.txt files and clean them up.

I would like to propose that we also change all the key words to lower case. The primary reason for this is that all documentation for CMakeLists.txt now shows the key words as lower case. Even the printed “Mastering CMake v5” uses lower case. I’ve come across this several times in my class where students stumble over the fact that the documentation about Cmake does not match the implementation in ITK.

I have a script (a wrapper around a vim macro) written that can make these substituions reliably (Tested on the BRAINS tree, the Slicer3 tree, and the ITK tree without causing any errors).

=====================
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? convert_cmake_to_lowercase.vim (4,072) 2010-08-30 18:00
https://public.kitware.com/Bug/file/3350/convert_cmake_to_lowercase.vim
txt HowToCreateTheCMakeCaseConversion.txt (1,197) 2010-09-16 09:15
https://public.kitware.com/Bug/file/3394/HowToCreateTheCMakeCaseConversion.txt
Issue History
Date ModifiedUsernameFieldChange
2010-08-26 09:35Hans JohnsonNew Issue
2010-08-26 09:36Hans JohnsonStatusnew => assigned
2010-08-26 09:36Hans JohnsonAssigned To => Hans Johnson
2010-08-30 18:00Hans JohnsonFile Added: convert_cmake_to_lowercase.vim
2010-08-30 18:01Hans JohnsonNote Added: 0022008
2010-08-30 18:02Hans JohnsonFile Added: HowToCreateTheCMakeCaseConversion.txt
2010-09-16 09:12Hans JohnsonNote Added: 0022257
2010-09-16 09:14Hans JohnsonFile Deleted: HowToCreateTheCMakeCaseConversion.txt
2010-09-16 09:15Hans JohnsonFile Added: HowToCreateTheCMakeCaseConversion.txt
2010-09-21 21:33Hans JohnsonResolution Date => 2010-09-16
2010-09-21 21:33Hans JohnsonSprint Status => backlog
2010-09-21 21:33Hans JohnsonNote Added: 0022310
2010-09-21 21:33Hans JohnsonStatusassigned => closed
2010-09-21 21:33Hans JohnsonResolutionopen => fixed
2010-09-21 21:33Hans JohnsonFixed in Version => ITK-4-A2

Notes
(0022008)
Hans Johnson   
2010-08-30 18:01   
export TMP_DIR=/tmp/


for ff in $(cat ${FILESTOCONVERT}); do
   echo "PROCESSING $ff";
   vim -S ${TMP_DIR}/convert_cmake_to_lowercase.vim $ff;
done
(0022257)
Hans Johnson   
2010-09-16 09:12   
As part of this effort, the subdirs command should be changed to the recommended add_subdirectory command.
(0022310)
Hans Johnson   
2010-09-21 21:33   
Addressed in commit number c50b6de4431716461477d38c5a491c071b75bf3b