[vtkusers] vtkAbstractMapper hierarchy uses non-virtual ShallowCopy?

[David E DeMarle]

Please do submit a merge request Andreas,

I don't see any reason for that not to be virtual.
It has been that way since at least 2001, maybe for efficiency.

thanks

David E DeMarle
Kitware, Inc.
Principal Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909


On Mon, Oct 22, 2018 at 3:26 AM Andreas Buykx <A.Buykx at dianafea.com> wrote:

> Hi,
>
>
>
> I noticed that the class hierarchy of vtkAbstractMapper has non-virtual
> ShallowCopy methods whereas the vtkDataObject and vtkProp hierarchies have
> virtual ShallowCopy. To me this came as a surprise. Is it intentional to
> have non-virtual ShallowCopy or can I make a contribution to make these
> virtual?
>
>
>
> Thanks,
>
> Andreas
>
>
>
> *DIANA FEA BV *
>
> *Software Developers and Analysis Consultants for Civil and Geotechnical
> Engineering *
>
>
>
> Delftechpark 19a, 2628XJ, Delft, The Netherlands
>
> Tel: +31 88 34262 15 (Direct) │ Tel: +31 88 34262 00 (Switchboard) │ Fax:
> +31 88 34262 99
>
> http://dianafea.com
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the VTK FAQ at:
> http://www.vtk.org/Wiki/VTK_FAQ
>
> Search the list archives at: http://markmail.org/search/?q=vtkusers
>
> Follow this link to subscribe/unsubscribe:
> https://public.kitware.com/mailman/listinfo/vtkusers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://public.kitware.com/pipermail/vtkusers/attachments/20181022/49abea7d/attachment.html>