[vtk-developers] rules proposal drop "+1" ie, looks ok to me but someone else needs to review as well

[David Lonie]

On Thu, Jul 7, 2016 at 8:56 AM, David E DeMarle <dave.demarle at kitware.com>
wrote:

> As Robert just pointed out, the +1 state in the review process is nothing
> but trouble. In practice, it seems to help us avoid responsibility and
> delays merging, contributing to the accumulation of stale merge requests
> and newbie frustration.
>
> How about we say "+1 means I approve this code and assert that it is ready
> to merge". Merge requests from a authorized developers should be promptly
> merged after the +1 by the original author. Merge requests from
> unauthorized developers should be merged more or less immediately by the
> authorized reviewer after the +1.
>

+1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20160707/2d289fe6/attachment.html>