[vtk-developers] Avoiding MR stagnation (was: rules proposal drop "+1")

Brad King brad.king at kitware.com
Thu Jul 7 09:56:09 EDT 2016


On 07/07/2016 08:56 AM, David E DeMarle wrote:
> In either case both authors and reviewers are responsible for
> watching the dashboards and addressing issues that come up afterward.

This is the real reason people are hesitant to +2.  If we strengthen
the meaning of +1 then people will just say "LGTM" or something else
to "approve" without taking responsibility.  Posting +1 is a common
convention for voting and should not be given stronger meaning.

The real problem we'd like to address is stagnation of MRs that
are ready but not merged.  The syntax for approving is not very
important.  We should identify reasons MRs stagnate and address
them directly:

* It may be a governance problem.  No one has responsibility
  to ensure everything that is ready gets merged.

* It may be a workflow problem, like waiting for buildbot results
  to approve and then forgetting.  The new workflow:buildbots
  label may help here.

-Brad



More information about the vtk-developers mailing list