[vtk-developers] Indentation style and converting to Doxygen style docs

Bill Lorensen bill.lorensen at gmail.com
Fri Jul 1 13:36:44 EDT 2016


KWStyle has worked pretty good for ITK.


On Fri, Jul 1, 2016 at 1:32 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> I've used it.  It has an unforgivable flaw: it doesn't count the whitespace
> at the beginning of the line as part of the line length when it does its
> maximum line length check.
>
> My experience with style checkers has been bad.  I find that people use them
> as a crutch, and write messy code because "the style checker can fix it
> before I commit".  In any case, my main concern is that people write tidy
> code, I'm less concerned about strictly following a specific style as long
> as each module is internally self-consistent.
>
>  - David
>
> On Fri, Jul 1, 2016 at 9:59 AM, Utkarsh Ayachit
> <utkarsh.ayachit at kitware.com> wrote:
>>
>> Maybe a little off topic, but has anyone looked at "Artistic Style"
>> (http://astyle.sourceforge.net/astyle.html).
>>
>> Seems like a project especially designed for changing formatting.
>>
>> Utkarsh
>>
>>
>> On Fri, Jul 1, 2016 at 9:49 AM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>>>
>>> Once the files are changed, I suggest that a KWStyle expert
>>> https://kitware.github.io/KWStyle/ take a stab at creating a VTK style
>>> file. That way we can enforce the style in the future. We use it in
>>> ITK and it is very effective, although it can take some effort to
>>> correct all of the existing defects.
>>>
>>>
>>> On Fri, Jul 1, 2016 at 9:23 AM, Ben Boeckel <ben.boeckel at kitware.com>
>>> wrote:
>>> > On Thu, Jun 30, 2016 at 17:09:18 -0600, David Gobbi wrote:
>>> >> The scripts just modify the VTK source files. They don't call any git
>>> >> commands so I don't think they can, by themselves, be idempotent.  Do
>>> >> you
>>> >> have any insights into what we can do to avoid conflicts?
>>> >
>>> > A function f is idempotent iff f(f(x)) == f(x). If the formatter is
>>> > idempotent, it can be safely run over any branch during a rebase to
>>> > make
>>> > it not add any style violations.
>>> >
>>> > --Ben
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>



-- 
Unpaid intern in BillsBasement at noware dot com


More information about the vtk-developers mailing list