[vtk-developers] Gitlab and interdiffs

Bill Lorensen bill.lorensen at gmail.com
Mon Apr 6 14:04:15 EDT 2015


What did gerrit do? There you could select which patches to diff. Very
convenient while reviewing.


On Mon, Apr 6, 2015 at 11:02 AM, Ben Boeckel <ben.boeckel at kitware.com> wrote:
> On Mon, Apr 06, 2015 at 11:47:05 -0600, David Gobbi wrote:
>> A straight diff will be an improvement (and it's too bad that gitlab's
>> compare tool
>> doesn't provide it as an option).  But that still won't give nice results
>> if the branch
>> is rebased.
>
> True, but this is also good for "what changed" reasons anyways, so I
> think having at least the `a b` link is good even if there's a better
> one availble. Is there a generic diff we could use to handle all the
> cases? Or would "the shorter of `a...b` and `a b`" be a good heuristic?
> I think ReviewBoard does it by diffing:
>
>     base...a
>     base...b
>
> and generating a diff view from that.
>
> --Ben
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>



-- 
Unpaid intern in BillsBasement at noware dot com


More information about the vtk-developers mailing list