[vtk-developers] reviewers to add?

Andrew Maclean andrew.amaclean at gmail.com
Tue Mar 11 18:04:25 EDT 2014


It sure will, thanks!
The odd thing was I have been doing Google searches and never found this
page!
All bookmarked now!

Thanks again.
Andrew



> ---------- Forwarded message ----------
> From: David E DeMarle <dave.demarle at kitware.com>
> To: Andrew Maclean <andrew.amaclean at gmail.com>
> Cc: VTK Developers <vtk-developers at vtk.org>
> Date: Tue, 11 Mar 2014 17:55:11 -0400
> Subject: Re: [vtk-developers] vtk-developers Digest, Vol 119, Issue 6
> I suspect this will help:
>
> http://gerrit.googlecode.com/svn-history/r3021/documentation/2.1.4/user-search.html
>
>
> David E DeMarle
> Kitware, Inc.
> R&D Engineer
> 21 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-881-4909
>
>
> On Tue, Mar 11, 2014 at 5:52 PM, Andrew Maclean <andrew.amaclean at gmail.com
> > wrote:
>
>>
>> Hi All,
>> "git log --follow" is a good idea.
>> Personally I have been trying to be a little more proactive in that I am
>> keeping an eye on all new submissions and reviewing things I know something
>> about especially when no reviewers have been added.
>>
>> This touches on a question that I asked a while back:
>> Does anyone know how to query gerrit looking for submissions that have no
>> reviewers added?
>>
>> A good case in point here was:
>> http://review.source.kitware.com/#/c/14373/ where there were no
>> reviewer(s) added. I only noticed it because I was monitoring all the
>> gerrit submissions.
>>
>> Regards
>>    Andrew
>>
>>
>>> ---------- Forwarded message ----------
>>> From: David E DeMarle <dave.demarle at kitware.com>
>>> To: xabivtk <xabivtk at gmail.com>
>>> Cc: vtkdev <vtk-developers at vtk.org>
>>> Date: Tue, 11 Mar 2014 10:09:56 -0400
>>> Subject: Re: [vtk-developers] reviewers to add?
>>> I do a "git log --follow" for the classes I intend to modify and ask the
>>> most recent few developers who have touched the classes in question.
>>>
>>> If I know who champions the code in question I ask them first. A very
>>> dated version of this bit is on:
>>> http://www.vtk.org/Wiki/VTK/Managing_the_Development_Process
>>> If anyone wants to update that and put it on a new page please do so.
>>>
>>>
>>> David E DeMarle
>>> Kitware, Inc.
>>> R&D Engineer
>>> 21 Corporate Drive
>>> Clifton Park, NY 12065-8662
>>> Phone: 518-881-4909
>>>
>>>
>>> On Tue, Mar 11, 2014 at 6:09 AM, xabivtk <xabivtk at gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I'm bringing back this question since i'm facing it now.
>>>> What is the recommendation to select the reviewers for gerrit?
>>>>
>>>> The first guess is to find one that has been implied at some time in the
>>>> classes we want to modify, but what if there are no one, or we want to
>>>> add
>>>> new classes?
>>>>
>>>> The wiki page for module/reviewers list as in ITK seems a good idea.
>>>>
>>>>
>>>>
>>>> --
>>>> View this message in context:
>>>> http://vtk.1045678.n5.nabble.com/reviewers-to-add-tp4892420p5726247.html
>>>> Sent from the VTK - Dev mailing list archive at Nabble.com.
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> vtk-developers mailing list
>>> vtk-developers at vtk.org
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>>
>>
>>
>> --
>> ___________________________________________
>> Andrew J. P. Maclean
>>
>> ___________________________________________
>>
>
>
> _______________________________________________
> vtk-developers mailing list
> vtk-developers at vtk.org
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>


-- 
___________________________________________
Andrew J. P. Maclean

___________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20140312/c16615f7/attachment-0002.html>


More information about the vtk-developers mailing list