<div dir="ltr">It sure will, thanks!<div>The odd thing was I have been doing Google searches and never found this page!<br><div>All bookmarked now!</div><div><br></div><div>Thanks again.</div><div>Andrew<br><div class="gmail_extra">
<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>---------- Forwarded message ----------<br>From: David E DeMarle <<a href="mailto:dave.demarle@kitware.com">dave.demarle@kitware.com</a>><br>
To: Andrew Maclean <<a href="mailto:andrew.amaclean@gmail.com">andrew.amaclean@gmail.com</a>><br>Cc: VTK Developers <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>><br>Date: Tue, 11 Mar 2014 17:55:11 -0400<br>
Subject: Re: [vtk-developers] vtk-developers Digest, Vol 119, Issue 6<br><div dir="ltr">I suspect this will help:<div><a href="http://gerrit.googlecode.com/svn-history/r3021/documentation/2.1.4/user-search.html" target="_blank">http://gerrit.googlecode.com/svn-history/r3021/documentation/2.1.4/user-search.html</a><br>
</div><div><br></div></div><div class="gmail_extra"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a></div>
<br><br><div class="gmail_quote">On Tue, Mar 11, 2014 at 5:52 PM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra">Hi All,</div><div class="gmail_extra">"git log --follow" is a good idea.</div><div class="gmail_extra">Personally I have been trying to be a little more proactive in that I am keeping an eye on all new submissions and reviewing things I know something about especially when no reviewers have been added. </div>
<div class="gmail_extra"><br></div><div class="gmail_extra">This touches on a question that I asked a while back:</div><div class="gmail_extra">Does anyone know how to query gerrit looking for submissions that have no reviewers added? </div>
<div class="gmail_extra"><br></div><div class="gmail_extra">A good case in point here was: <a href="http://review.source.kitware.com/#/c/14373/" target="_blank">http://review.source.kitware.com/#/c/14373/</a> where there were no reviewer(s) added. I only noticed it because I was monitoring all the gerrit submissions.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Regards</div><div class="gmail_extra"> Andrew<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>---------- Forwarded message ----------<br>From: David E DeMarle <<a href="mailto:dave.demarle@kitware.com" target="_blank">dave.demarle@kitware.com</a>><br>To: xabivtk <<a href="mailto:xabivtk@gmail.com" target="_blank">xabivtk@gmail.com</a>><br>
Cc: vtkdev <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>Date: Tue, 11 Mar 2014 10:09:56 -0400<br>Subject: Re: [vtk-developers] reviewers to add?<br><div dir="ltr">I do a "git log --follow" for the classes I intend to modify and ask the most recent few developers who have touched the classes in question.<div>
<br></div><div>If I know who champions the code in question I ask them first. A very dated version of this bit is on: <a href="http://www.vtk.org/Wiki/VTK/Managing_the_Development_Process" target="_blank">http://www.vtk.org/Wiki/VTK/Managing_the_Development_Process</a></div>
<div>If anyone wants to update that and put it on a new page please do so.<br><div><br></div></div></div><div class="gmail_extra"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>
Clifton Park, NY 12065-8662<br>Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a></div>
<br><br><div class="gmail_quote">On Tue, Mar 11, 2014 at 6:09 AM, xabivtk <span dir="ltr"><<a href="mailto:xabivtk@gmail.com" target="_blank">xabivtk@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hi,<br>
<br>
I'm bringing back this question since i'm facing it now.<br>
What is the recommendation to select the reviewers for gerrit?<br>
<br>
The first guess is to find one that has been implied at some time in the<br>
classes we want to modify, but what if there are no one, or we want to add<br>
new classes?<br>
<br>
The wiki page for module/reviewers list as in ITK seems a good idea.<br>
<br>
<br>
<br>
--<br>
View this message in context: <a href="http://vtk.1045678.n5.nabble.com/reviewers-to-add-tp4892420p5726247.html" target="_blank">http://vtk.1045678.n5.nabble.com/reviewers-to-add-tp4892420p5726247.html</a><br>
Sent from the VTK - Dev mailing list archive at Nabble.com.<br>
<div><div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br></div>
<br>_______________________________________________<br>
vtk-developers mailing list<br>
<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________
</font></span></div></div>
</blockquote></div><br></div>
<br>_______________________________________________<br>
vtk-developers mailing list<br>
<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a><br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________
</div></div></div></div>