[vtk-developers] Possible vtkScalarBarActor improvement

Mon Oct 28 15:58:16 EDT 2013

Hi Marcus,

In that specific case, I think Kevin is talking about:

 1) back-porting the following commits:

https://github.com/Kitware/VTK/commit/de162c7bc3371f8f6853084f25d8b053378037a8

  and

 2) also adding some custom code:
https://github.com/kevinwangcanada/VTK/commit/9afad570e64bf9137a9f988c9346901ee8d0191c#diff-2

I am sure Kevin will able to provide more details.

Is it conceivable to at least backport the commit reference in (1), that
would us to more easily customize the widget for Slicer.

Regarding (2), assuming Kevin adds a test for it would it make sense to
integrate it to VTK 5.10.x ? It would avoid to add custom widget/code that
would be useless after transitioning to VTK6.

As a side note, would like to let you know that we are also actively
working to update Slicer code base to be VTK6 ready.

Thanks
Jc

---------- Forwarded message ----------
From: Marcus D. Hanwell <marcus.hanwell at kitware.com>
Date: Mon, Oct 28, 2013 at 3:04 PM
Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
To: Jean-Christophe Fillion-Robin <jchris.fillionr at kitware.com>
Cc: "Wang, Kevin" <kevin.wang at rmp.uhn.on.ca>, "vtk-developers at vtk.org" <
vtk-developers at vtk.org>

Jc, this sounds a lot like a feature to me, and we specifically
outlined that the branch is open to conservative bug/compile fixes. Of
course Slicer might have different policies for its 5.10 integration
branch.

On Mon, Oct 28, 2013 at 2:25 PM, Jean-Christophe Fillion-Robin
<jchris.fillionr at kitware.com> wrote:
> Hi Kevin,
>
> Could you close and resubmit your request against the `slicer-v5.10.1`
> branch ?
>
> In the mean time, the VTK contribution workflow has been updated to accept
> contribution for VTK 5.10.x. Would be great if you could also submit a
topic
> on VTK proper.
>
> See here for more details:
>
http://vtk.1045678.n5.nabble.com/Gerrit-release-5-10-branch-now-open-for-backported-fixes-td5724188.html
>
> Thanks
> Jc
>
>
> On Mon, Oct 7, 2013 at 10:20 AM, Wang, Kevin <kevin.wang at rmp.uhn.on.ca>
> wrote:
>>
>> Thanks Jc. I have created a pull request at
>> https://github.com/Slicer/VTK/pull/1
>>
>>
>>
>> Please review and let me know.
>>
>>
>>
>> Kevin
>>
>>
>>
>> From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com]
>> Sent: Friday, October 04, 2013 11:57 AM
>>
>>
>> To: Wang, Kevin
>> Cc: David Thompson; vtk-developers at vtk.org
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
>>
>>
>>
>> Hi Kevin,
>>
>> Could you submit a pull request on the SlicerVTK fork ? It will make the
>> review process easier. Make sure to base your topic of commit
0e0674a3695f.
>>
>> Thanks
>>
>> Jc
>>
>>
>>
>> On Fri, Sep 27, 2013 at 2:26 PM, Wang, Kevin <kevin.wang at rmp.uhn.on.ca>
>> wrote:
>>
>> Thanks Jc for the info.
>>
>>
>>
>> Attached are the patches for vtk. I just used vtkScalarsToColors.h and
>> vtkScalarsToColors.h from vtk 6.0 without any changes and it is compiling
>> and working fine. For vtkScalarBarActor class, I just added a small
section
>> to check if there is annotations set for the lookupTable then use the
>> annotations as the label.
>>
>>
>>
>> David, can you please take a look to see if it needs improvement. If
>> everything is fine, I will submit a pull request within SlicerVTK fork.
>>
>>
>>
>> Thanks again,
>>
>>
>>
>> Kevin
>>
>>
>>
>> From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com]
>> Sent: Friday, September 27, 2013 12:25 PM
>>
>>
>> To: Wang, Kevin
>> Cc: David Thompson; vtk-developers at vtk.org
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
>>
>>
>>
>> Hi Kevin,
>>
>> Great :)
>>
>>
>>
>> The patch should be both sent:
>>
>>     - to VTK dev list for integration to 5.10 release branch  (gerrit is
>> not yet ready to work with 5.10 release branch [1])
>>
>>     - as pull request based on commit 0e0674a3 [2] associated with branch
>> "slicer-v5.10.1" [3] within SlicerVTK fork.
>>
>> Let me know if you have any questions,
>>
>> Jc
>>
>> [1]
>> http://vtk.1045678.n5.nabble.com/5-10-1-question-td5723589.html#a5723591
>>
>> [2]
>>
https://github.com/Slicer/VTK/commit/0e0674a3695fdeaf01ce87dfc04e32111b7402e0
>>
>> [3] https://github.com/Slicer/VTK/tree/slicer-v5.10.1
>>
>>
>>
>> On Fri, Sep 27, 2013 at 11:55 AM, Wang, Kevin <kevin.wang at rmp.uhn.on.ca>
>> wrote:
>>
>> Hi Jc,
>>
>>
>>
>> I am almost done with the backporting and other changes to VTK5.10 and
>> slicer. You mentioned that the changes in vtk can be integrated into the
>> SlicerVTK clone [1]. however, I am not clear on how to proceed. Do I
follow
>> the common practice to fork the slicerVTK repository and create a pull
>> request or something else?
>>
>>
>>
>> Thanks,
>>
>>
>>
>> Kevin
>>
>>
>>
>>
>>
>> [1] https://github.com/Slicer/VTK
>>
>>
>>
>> From: Jean-Christophe Fillion-Robin [mailto:jchris.fillionr at kitware.com]
>> Sent: Thursday, September 19, 2013 11:19 AM
>> To: Wang, Kevin
>> Cc: David Thompson; vtk-developers at vtk.org
>>
>>
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
>>
>>
>>
>> Make sense. Let us know when you have your topic updated.
>>
>> Thanks for your hard work :)
>>
>> Jc
>>
>>
>>
>> On Tue, Sep 17, 2013 at 11:27 AM, Wang, Kevin <kevin.wang at rmp.uhn.on.ca>
>> wrote:
>>
>> Hi Jc and David,
>>
>> I think one reasonable solution would be to backport vtkScalarsToColors,
>> but not backport vtkScalarBarActor. Instead we modify vtkScalarBarActor
>> slightly to handle the new annotation functionality in
vtkScalarsToColors.
>> Then in slicer, we keep several sets of vtkStringArrays around and switch
>> them in vtkScalarsToColors when needed. This way when we transition to
>> vtk6.0, there will be minimal changes.
>>
>> Thanks,
>>
>>
>> Kevin
>>
>> -----Original Message-----
>> From: David Thompson [mailto:david.thompson at kitware.com]
>>
>> Sent: Tuesday, September 17, 2013 11:16 AM
>> To: Jean-Christophe Fillion-Robin
>> Cc: Wang, Kevin; vtk-developers at vtk.org
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement
>>
>> Hi JC,
>>
>> > ...
>> > @David: Do you see anything in the API proposed by Kevin that could be
>> > changed to be closer to what is possible in VTK 6 ?
>> >
https://github.com/kevinwangcanada/Slicer/commit/551c8b7f435b518664eef2917818addf78c853e6
>>
>> I would not backport vtkScalarBarActor, but you could backport
>> vtkScalarsToColors pretty easily and use it to store color names...
that's
>> where they are stored in VTK6.
>>
>>         David
>>
>> This e-mail may contain confidential and/or privileged information for
the
>> sole use of the intended recipient.
>> Any review or distribution by anyone other than the person for whom it
was
>> originally intended is strictly prohibited.
>> If you have received this e-mail in error, please contact the sender and
>> delete all copies.
>> Opinions, conclusions or other information contained in this e-mail may
>> not be that of the organization.
>>
>>
>>
>>
>> --
>> +1 919 869 8849
>>
>>
>> This e-mail may contain confidential and/or privileged information for
the
>> sole use of the intended recipient.
>> Any review or distribution by anyone other than the person for whom it
was
>> originally intended is strictly prohibited.
>> If you have received this e-mail in error, please contact the sender and
>> delete all copies.
>> Opinions, conclusions or other information contained in this e-mail may
>> not be that of the organization.
>>
>>
>>
>>
>> --
>> +1 919 869 8849
>>
>>
>> This e-mail may contain confidential and/or privileged information for
the
>> sole use of the intended recipient.
>> Any review or distribution by anyone other than the person for whom it
was
>> originally intended is strictly prohibited.
>> If you have received this e-mail in error, please contact the sender and
>> delete all copies.
>> Opinions, conclusions or other information contained in this e-mail may
>> not be that of the organization.
>>
>>
>>
>>
>> --
>> +1 919 869 8849
>>
>>
>> This e-mail may contain confidential and/or privileged information for
the
>> sole use of the intended recipient.
>> Any review or distribution by anyone other than the person for whom it
was
>> originally intended is strictly prohibited.
>> If you have received this e-mail in error, please contact the sender and
>> delete all copies.
>> Opinions, conclusions or other information contained in this e-mail may
>> not be that of the organization.
>
>
>
>
> --
> +1 919 869 8849
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>

-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20131028/3adf9617/attachment.html>