<div dir="ltr"><div>Hi Marcus, <br><br></div><div>In that specific case, I think Kevin is talking about:<br><br> 1) back-porting the following commits:<br> <a href="https://github.com/Kitware/VTK/commit/de162c7bc3371f8f6853084f25d8b053378037a8" target="_blank">https://github.com/Kitware/VTK/commit/de162c7bc3371f8f6853084f25d8b053378037a8</a><br>
<br></div><div> and <br><br> 2) also adding some custom code: <a href="https://github.com/kevinwangcanada/VTK/commit/9afad570e64bf9137a9f988c9346901ee8d0191c#diff-2" target="_blank">https://github.com/kevinwangcanada/VTK/commit/9afad570e64bf9137a9f988c9346901ee8d0191c#diff-2</a><br>
<br><br></div><div>I am sure Kevin will able to provide more details.<br></div><div><br></div><div>Is it conceivable to at least backport the commit reference in (1), that would us to more easily customize the widget for Slicer.<br>
<br></div><div>Regarding (2), assuming Kevin adds a test for it would it make sense to integrate it to VTK 5.10.x ? It would avoid to add custom widget/code that would be useless after transitioning to VTK6.<br>
<br></div><div>As a side note, would like to let you know that we are also actively working to update Slicer code base to be VTK6 ready.<br><br></div><div>Thanks<br></div><div>Jc<br></div><div><br></div><div><div><br><div class="gmail_quote">
---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Marcus D. Hanwell</b> <span dir="ltr"><<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>></span><br>
Date: Mon, Oct 28, 2013 at 3:04 PM<br>Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement<br>To: Jean-Christophe Fillion-Robin <<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>><br>
Cc: "Wang, Kevin" <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>>, "<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>" <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>
<br><br>Jc, this sounds a lot like a feature to me, and we specifically<br>
outlined that the branch is open to conservative bug/compile fixes. Of<br>
course Slicer might have different policies for its 5.10 integration<br>
branch.<br>
<div><div><br>
On Mon, Oct 28, 2013 at 2:25 PM, Jean-Christophe Fillion-Robin<br>
<<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>> wrote:<br>
> Hi Kevin,<br>
><br>
> Could you close and resubmit your request against the `slicer-v5.10.1`<br>
> branch ?<br>
><br>
> In the mean time, the VTK contribution workflow has been updated to accept<br>
> contribution for VTK 5.10.x. Would be great if you could also submit a topic<br>
> on VTK proper.<br>
><br>
> See here for more details:<br>
> <a href="http://vtk.1045678.n5.nabble.com/Gerrit-release-5-10-branch-now-open-for-backported-fixes-td5724188.html" target="_blank">http://vtk.1045678.n5.nabble.com/Gerrit-release-5-10-branch-now-open-for-backported-fixes-td5724188.html</a><br>
><br>
> Thanks<br>
> Jc<br>
><br>
><br>
> On Mon, Oct 7, 2013 at 10:20 AM, Wang, Kevin <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>><br>
> wrote:<br>
>><br>
>> Thanks Jc. I have created a pull request at<br>
>> <a href="https://github.com/Slicer/VTK/pull/1" target="_blank">https://github.com/Slicer/VTK/pull/1</a><br>
>><br>
>><br>
>><br>
>> Please review and let me know.<br>
>><br>
>><br>
>><br>
>> Kevin<br>
>><br>
>><br>
>><br>
>> From: Jean-Christophe Fillion-Robin [mailto:<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>]<br>
>> Sent: Friday, October 04, 2013 11:57 AM<br>
>><br>
>><br>
>> To: Wang, Kevin<br>
>> Cc: David Thompson; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement<br>
>><br>
>><br>
>><br>
>> Hi Kevin,<br>
>><br>
>> Could you submit a pull request on the SlicerVTK fork ? It will make the<br>
>> review process easier. Make sure to base your topic of commit 0e0674a3695f.<br>
>><br>
>> Thanks<br>
>><br>
>> Jc<br>
>><br>
>><br>
>><br>
>> On Fri, Sep 27, 2013 at 2:26 PM, Wang, Kevin <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>><br>
>> wrote:<br>
>><br>
>> Thanks Jc for the info.<br>
>><br>
>><br>
>><br>
>> Attached are the patches for vtk. I just used vtkScalarsToColors.h and<br>
>> vtkScalarsToColors.h from vtk 6.0 without any changes and it is compiling<br>
>> and working fine. For vtkScalarBarActor class, I just added a small section<br>
>> to check if there is annotations set for the lookupTable then use the<br>
>> annotations as the label.<br>
>><br>
>><br>
>><br>
>> David, can you please take a look to see if it needs improvement. If<br>
>> everything is fine, I will submit a pull request within SlicerVTK fork.<br>
>><br>
>><br>
>><br>
>> Thanks again,<br>
>><br>
>><br>
>><br>
>> Kevin<br>
>><br>
>><br>
>><br>
>> From: Jean-Christophe Fillion-Robin [mailto:<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>]<br>
>> Sent: Friday, September 27, 2013 12:25 PM<br>
>><br>
>><br>
>> To: Wang, Kevin<br>
>> Cc: David Thompson; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement<br>
>><br>
>><br>
>><br>
>> Hi Kevin,<br>
>><br>
>> Great :)<br>
>><br>
>><br>
>><br>
>> The patch should be both sent:<br>
>><br>
>> - to VTK dev list for integration to 5.10 release branch (gerrit is<br>
>> not yet ready to work with 5.10 release branch [1])<br>
>><br>
>> - as pull request based on commit 0e0674a3 [2] associated with branch<br>
>> "slicer-v5.10.1" [3] within SlicerVTK fork.<br>
>><br>
>> Let me know if you have any questions,<br>
>><br>
>> Jc<br>
>><br>
>> [1]<br>
>> <a href="http://vtk.1045678.n5.nabble.com/5-10-1-question-td5723589.html#a5723591" target="_blank">http://vtk.1045678.n5.nabble.com/5-10-1-question-td5723589.html#a5723591</a><br>
>><br>
>> [2]<br>
>> <a href="https://github.com/Slicer/VTK/commit/0e0674a3695fdeaf01ce87dfc04e32111b7402e0" target="_blank">https://github.com/Slicer/VTK/commit/0e0674a3695fdeaf01ce87dfc04e32111b7402e0</a><br>
>><br>
>> [3] <a href="https://github.com/Slicer/VTK/tree/slicer-v5.10.1" target="_blank">https://github.com/Slicer/VTK/tree/slicer-v5.10.1</a><br>
>><br>
>><br>
>><br>
>> On Fri, Sep 27, 2013 at 11:55 AM, Wang, Kevin <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>><br>
>> wrote:<br>
>><br>
>> Hi Jc,<br>
>><br>
>><br>
>><br>
>> I am almost done with the backporting and other changes to VTK5.10 and<br>
>> slicer. You mentioned that the changes in vtk can be integrated into the<br>
>> SlicerVTK clone [1]. however, I am not clear on how to proceed. Do I follow<br>
>> the common practice to fork the slicerVTK repository and create a pull<br>
>> request or something else?<br>
>><br>
>><br>
>><br>
>> Thanks,<br>
>><br>
>><br>
>><br>
>> Kevin<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> [1] <a href="https://github.com/Slicer/VTK" target="_blank">https://github.com/Slicer/VTK</a><br>
>><br>
>><br>
>><br>
>> From: Jean-Christophe Fillion-Robin [mailto:<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>]<br>
>> Sent: Thursday, September 19, 2013 11:19 AM<br>
>> To: Wang, Kevin<br>
>> Cc: David Thompson; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>><br>
>><br>
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement<br>
>><br>
>><br>
>><br>
>> Make sense. Let us know when you have your topic updated.<br>
>><br>
>> Thanks for your hard work :)<br>
>><br>
>> Jc<br>
>><br>
>><br>
>><br>
>> On Tue, Sep 17, 2013 at 11:27 AM, Wang, Kevin <<a href="mailto:kevin.wang@rmp.uhn.on.ca" target="_blank">kevin.wang@rmp.uhn.on.ca</a>><br>
>> wrote:<br>
>><br>
>> Hi Jc and David,<br>
>><br>
>> I think one reasonable solution would be to backport vtkScalarsToColors,<br>
>> but not backport vtkScalarBarActor. Instead we modify vtkScalarBarActor<br>
>> slightly to handle the new annotation functionality in vtkScalarsToColors.<br>
>> Then in slicer, we keep several sets of vtkStringArrays around and switch<br>
>> them in vtkScalarsToColors when needed. This way when we transition to<br>
>> vtk6.0, there will be minimal changes.<br>
>><br>
>> Thanks,<br>
>><br>
>><br>
>> Kevin<br>
>><br>
>> -----Original Message-----<br>
>> From: David Thompson [mailto:<a href="mailto:david.thompson@kitware.com" target="_blank">david.thompson@kitware.com</a>]<br>
>><br>
>> Sent: Tuesday, September 17, 2013 11:16 AM<br>
>> To: Jean-Christophe Fillion-Robin<br>
>> Cc: Wang, Kevin; <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>> Subject: Re: [vtk-developers] Possible vtkScalarBarActor improvement<br>
>><br>
>> Hi JC,<br>
>><br>
>> > ...<br>
>> > @David: Do you see anything in the API proposed by Kevin that could be<br>
>> > changed to be closer to what is possible in VTK 6 ?<br>
>> > <a href="https://github.com/kevinwangcanada/Slicer/commit/551c8b7f435b518664eef2917818addf78c853e6" target="_blank">https://github.com/kevinwangcanada/Slicer/commit/551c8b7f435b518664eef2917818addf78c853e6</a><br>
>><br>
>> I would not backport vtkScalarBarActor, but you could backport<br>
>> vtkScalarsToColors pretty easily and use it to store color names... that's<br>
>> where they are stored in VTK6.<br>
>><br>
>> David<br>
>><br>
>> This e-mail may contain confidential and/or privileged information for the<br>
>> sole use of the intended recipient.<br>
>> Any review or distribution by anyone other than the person for whom it was<br>
>> originally intended is strictly prohibited.<br>
>> If you have received this e-mail in error, please contact the sender and<br>
>> delete all copies.<br>
>> Opinions, conclusions or other information contained in this e-mail may<br>
>> not be that of the organization.<br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> <a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
>><br>
>><br>
>> This e-mail may contain confidential and/or privileged information for the<br>
>> sole use of the intended recipient.<br>
>> Any review or distribution by anyone other than the person for whom it was<br>
>> originally intended is strictly prohibited.<br>
>> If you have received this e-mail in error, please contact the sender and<br>
>> delete all copies.<br>
>> Opinions, conclusions or other information contained in this e-mail may<br>
>> not be that of the organization.<br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> <a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
>><br>
>><br>
>> This e-mail may contain confidential and/or privileged information for the<br>
>> sole use of the intended recipient.<br>
>> Any review or distribution by anyone other than the person for whom it was<br>
>> originally intended is strictly prohibited.<br>
>> If you have received this e-mail in error, please contact the sender and<br>
>> delete all copies.<br>
>> Opinions, conclusions or other information contained in this e-mail may<br>
>> not be that of the organization.<br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> <a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
>><br>
>><br>
>> This e-mail may contain confidential and/or privileged information for the<br>
>> sole use of the intended recipient.<br>
>> Any review or distribution by anyone other than the person for whom it was<br>
>> originally intended is strictly prohibited.<br>
>> If you have received this e-mail in error, please contact the sender and<br>
>> delete all copies.<br>
>> Opinions, conclusions or other information contained in this e-mail may<br>
>> not be that of the organization.<br>
><br>
><br>
><br>
><br>
> --<br>
> <a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
><br>
</div></div><div><div>> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
</div></div></div><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
</div></div></div>