[vtk-developers] Should we halt gerrit merges?

Bill Lorensen bill.lorensen at gmail.com
Tue Mar 26 16:01:33 EDT 2013


No. Just block topics that are not fixing the current issues.


On Tue, Mar 26, 2013 at 12:54 PM, Marcus D. Hanwell <
marcus.hanwell at kitware.com> wrote:

> On Tue, Mar 26, 2013 at 3:11 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> > Can't you try the patch during the day on a failing nightly?
> >
> I asked Rob to try a Windows Python experimental on the topic, it is
> very low risk as we tracked the issue to the wrap hierarchy seeing new
> headers and the patch removes them from the module headers
> (effectively reverting the majority of the part of the patch that
> added more headers to the vtkCommonCore module). It was an unforeseen
> issue, but I think the best path is to merge fixes but will hopefully
> here back from Rob shortly.
>
> I am out of the office, and will probably be in and out tomorrow, are
> you wanting to block merging fixes in too until they are manually run
> on Windows? The two topics are minimal changes to fix the issues we
> saw in the results to the nightly, and without the coverage of the
> nightly dashboards it will be hard to be certain we covered all of the
> corner cases.
>
> Marcus
>



-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130326/668a755b/attachment.html>


More information about the vtk-developers mailing list