[vtk-developers] DoublePi proposal

[Bill Lorensen]

David,

I'm in no hurry to push the topic. I'll keep it active as we get more
regressions.

Bill

On Mon, May 14, 2012 at 6:38 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> Bill, the main reason that I put my patch on hold was that I wanted to
> wait until VTK 6 had reached at least the same level of test coverage
> as VTK 5.  I still think that this is a valid reason for keeping this
> patch on hold.  The added pi precision will cause subtle changes in
> many regression images, and some of the changes will be significant
> enough to cause test failures.  That's great if all the regression
> tests are running, because we can examine any test failures that occur
> and replace the regression images as necessary.
>
> But right now in VTK 6, about half of our regression tests aren't
> running.  So if this Pi patch is pushed now, we won't see all the
> regression test failures immediately.  We'll see some regression test
> failures some weeks (or months?) later as the various tests are
> re-activated, and we won't be sure if the failures were caused by this
> patch, or if they were caused by some other patch.
>
>  - David
>
>
> On Mon, May 14, 2012 at 11:59 AM, David Gobbi <david.gobbi at gmail.com> wrote:
>> http://review.source.kitware.com/#/t/427/
>>
>>
>> On Mon, May 14, 2012 at 10:50 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>> David,
>>>
>>> Can you point me to the gerrit topic? If not, I can start from scratch.
>>>
>>> Bill



-- 
Unpaid intern in BillsBasement at noware dot com