[vtk-developers] reviewers to add?

tom fogal tfogal at sci.utah.edu
Tue Oct 11 13:55:03 EDT 2011

"Marcus D. Hanwell" <marcus.hanwell at kitware.com> writes:
> On Tue, Oct 11, 2011 at 1:23 PM, tom fogal <tfogal at sci.utah.edu> wrote:
> > On 10/11/2011 11:18 AM, Sean McBride wrote:
> >>
> >> On Tue, 11 Oct 2011 10:48:44 -0600, tom fogal said:
> >>>
> >>> I can't find any information on reviewers to add. =A0There's
> >>> now some patches that I feel are appropriate for master or even
> >>> release. =A0Who should I add that can review and then shepherd
> >>> things from gerrit to gi t?
> >>
> >> I've wondered that too. =A0ITK has a list here:
> >> <http://www.vtk.org/Wiki/ITK/Gerrit/Reviewers>
> >
> > Yeah, I found the ITK one but it was course not much use for VTK.
> I will see about putting together a similar list for VTK.


> I will try to dig into some of your patches and assign appropriate
> reviewers/review them. I am certainly not a bad choice for some of
> the rendering changes.

I actually abandoned all the rendering changes.  I'm planning on
redoing them after you merge in your 'vtkmodular' branch, since that
moves most of the files I touch into a Rendering/OpenGL/ directory.

> We have an internal test Gerrit server where we can do some build
> testing on topics in much the same was as ITK on commits. I am
> hoping to get this ready to be rolled out in the next few weeks to
> streamline the build testing side of this. I will grab the branch and
> push it there to see how well it builds.

Oh, oops; I have been dropping large swathes of changes, and don't
really have any big branches left.  All of the large sets of changes
had a variety of states, from 'ready to ship' to 'eh, this compiles on
Linux and Mac and seems to work for us...'  At present time, you might
try the 'visit-ready' topic.

I'm still not entirely sure how to get people motivated to take a look
at code, here.  As you saw with your modular branch, "take a look
at this branch on gitorious" doesn't get much review.  Posting to
gerrit gets some, but I seem to overwhelm people if I post an entire
branch.  Doesn't seem like there's a method to vet WIP code... maybe
individually posting patches to the ML?



More information about the vtk-developers mailing list