[vtk-developers] Rename vtkBoostBreadthFirstSearch?

[Mclendon, William C III]

Generally speaking, I believe the naming convention on the VTK filters that use BGL algorithms has been to name the filter after the BGL algorithm that it's calling.  Since vtkBoostBreadthFirstSearch relies on the BGL breadth-first search algorithm we use that name.

In the current form it only executes a BFS with a specific visitor class that just records the distance from the root.  Perhaps rather than renaming the class to match the default behavior, we should think about changes that allow the visitor class to be customized?  The default behavior should probably remain the same though...

-William



On 3/29/10 2:58 PM, "Moreland, Kenneth" <kmorel at sandia.gov> wrote:

If the filter relies on Boost, then it should have Boost in the name (i.e. vtkBoostGraphDistanceFilter).  I don't use these filters much so beyond that I am pretty agnostic.

-Ken


On 3/28/10 12:23 PM, "David Doria" <daviddoria+vtk at gmail.com> wrote:

It looks like the only function of vtkBoostBreadthFirstSearch is to compute the distance from every vertex to the origin vertex and append a vtkIntArray to the input graph containing these values. If that is correct, the name of the class seems very confusing to me. Could it be changed to something more like vtkGraphDistanceFilter or something like that?

Thanks,

David



   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100329/cba1294a/attachment.html>