[vtk-developers] New git commit hooks

Dave Partyka dave.partyka at kitware.com
Fri Apr 23 10:52:35 EDT 2010


Exactly. IMHO, this is easier done committing interactively with git commit
<enter> and letting your favorite editor open up.

On Fri, Apr 23, 2010 at 10:43 AM, David Gobbi <david.gobbi at gmail.com> wrote:

> I have a quick question about commit messages.  The pre-commit hook
> tells me that the first line of the commit message must be 78 chars or
> less, and the second line must be blank.
>
> So how should commit messages be structured?  A short descriptive
> line, followed by a blank line, followed optionally by one or two
> sentences giving details of the change?
>
>   David
>
>
> On Fri, Apr 23, 2010 at 6:50 AM, Robert Maynard
> <robert.maynard at kitware.com> wrote:
> >
> >
> > On Fri, Apr 23, 2010 at 2:24 AM, Mark Olesen <Mark.Olesen at faurecia.com>
> > wrote:
> >>
> >> On Fri, 2010-04-23 at 10:34 +1000, Andrew Maclean wrote:
> >> > I agree with you, I  think that there also should be a commit check
> >> > for tabs,  otherwise layout gets really messy.
> >>
> >> What about checking/stripping trailing whitespace as well?
> >> This is something else that tends to look messy and result in lots of
> >> noisy commits.
> >>
> >> /mark
> >>
> >>
> >> DISCLAIMER:
> >> This electronic transmission (and any attachments thereto) is intended
> >> solely for the use of the addressee(s). It may contain confidential or
> >> legally privileged information. If you are not the intended recipient of
> >> this message, you must delete it immediately and notify the sender. Any
> >> unauthorized use or disclosure of this message is strictly prohibited.
> >> Faurecia does not guarantee the integrity of this transmission and shall
> >> therefore never be liable if the message is altered or falsified nor for
> any
> >> virus, interception or damage to your system.
> >>
> >> _______________________________________________
> >> Powered by www.kitware.com
> >>
> >> Visit other Kitware open-source projects at
> >> http://www.kitware.com/opensource/opensource.html
> >>
> >> Follow this link to subscribe/unsubscribe:
> >> http://www.vtk.org/mailman/listinfo/vtk-developers
> >>
> >
> > http://www.paraview.org/Wiki/VTK/Git#Hooks Will show you how to copy the
> > server commit checks for use on local commits.
> > --
> > Robert Maynard
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
> >
> >
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100423/617180f6/attachment.html>


More information about the vtk-developers mailing list