[vtk-developers] vtkImageConvolve -- why is it there?

[Will Schroeder]

Hi David-

This was a class contributed by an outside party and sent to me. I threw it in the repository because I like to encourage contribution and I like to have the testing process chew on it to flesh out the bugs. As you can see it was renamed to vtkImageVectorConvolve because others had the same concerns that you did. The testing process also found some problems including the bad indexing. I tend to trust to the extreme programming process more (meaning poke something and see what emerges) rather than the cathedral approach of up front agreement on everything, which I know introduce chaos at time. I agree that certain additions need more discussion as this one did. I will definitely keep this in mind in the future.

Will

At 11:47 PM 5/21/2001 -0400, David Gobbi wrote:
>I was looking through the CVS entries for today and there was
>a new class, vtkImageConvolve, that doesn't look like it belongs.
>
>It convolves the image with a 3-element linear kernel (?) and is
>therefore not general enough to be called 'vtkImageConvolve'
>(a general convolution filter should accept an NxNxN kernel),
>it computes the convolution incorrectly, and it has clearly
>never been tested because the 'kernel' indices are in
>the range [1,3] instead of [0,2] i.e. if it had been tested
>it would have either given grossly incorrect results or would
>have segfaulted.
>
>I've sent this plea out before, but I'll say it again.  Can't
>we have some discussion on this list before new classes are
>added or before major API changes are committed?
>
> - David
>
>--
>  David Gobbi, MSc                    dgobbi at irus.rri.on.ca
>  Advanced Imaging Research Group
>  Robarts Research Institute, University of Western Ontario
>
>
>_______________________________________________
>vtk-developers mailing list
>vtk-developers at public.kitware.com
>http://public.kitware.com/mailman/listinfo/vtk-developers