[vtk-developers] vtkImageConvolve -- why is it there?

David Gobbi dgobbi at irus.rri.on.ca
Mon May 21 23:47:45 EDT 2001


I was looking through the CVS entries for today and there was
a new class, vtkImageConvolve, that doesn't look like it belongs.

It convolves the image with a 3-element linear kernel (?) and is
therefore not general enough to be called 'vtkImageConvolve'
(a general convolution filter should accept an NxNxN kernel),
it computes the convolution incorrectly, and it has clearly
never been tested because the 'kernel' indices are in
the range [1,3] instead of [0,2] i.e. if it had been tested
it would have either given grossly incorrect results or would
have segfaulted.

I've sent this plea out before, but I'll say it again.  Can't
we have some discussion on this list before new classes are
added or before major API changes are committed?

 - David

--
  David Gobbi, MSc                    dgobbi at irus.rri.on.ca
  Advanced Imaging Research Group
  Robarts Research Institute, University of Western Ontario





More information about the vtk-developers mailing list