[Cdash] Suggested patch to version 222 with regards to redirection to https:// from user.php

[Julien Jomier]

Dear Kristofer,

Thanks for submitting the patch. I have logged a bug in the bug tracker 
and we'll try to integrate it when we can:

   http://public.kitware.com/Bug/view.php?id=14995

Thanks again,
Julien

On 26/06/2014 16:06, Kristofer Tingdahl wrote:
> Hi,
>
> 1. Thanks for version 222!!
> 2. My system administrator installed cdash 222, and everything went well
> (in general). We did however have a problem as loading user.php
> redirects to https, while our setup does not support that. As our system
> is in a shielded off network, we don't see the need for it.
>
> The current functionality calls redirect_to_https(). My problem is that
> the check that is done at:
>
> $https_check = @fsockopen($_SERVER['HTTP_HOST']);
>
>
> does check the http connection (which works), and not a https
> connection. The attached patch changes that, so the test becomes more
> realistic to what we are about to do. I guess that this is only half
> way, as you may wish the possibility to set the port of the https-call
> than to the current http call. That is not covered by my patch.
>
>
> I can see that in a public system, it is indeed very useful to do this
> redirection. In the light of this, I am proposing a patch (as attached)
> for your consideration.
>
>
> Cheers,
>
>
> Kristofer Tingdahl
>
>
> _______________________________________________
> Cdash mailing list
> Cdash at public.kitware.com
> http://public.kitware.com/mailman/listinfo/cdash
>