View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014995

CDash

(No Category)

public

2014-06-27 04:12

2014-06-27 14:21

Reporter

Julien Jomier

Assigned To

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

2.2

Target Version

2.4

Fixed in Version

Summary

0014995: User page HTTPS redirect only when HTTPS is available

Description

CDash user.php redirects to HTTPS but this doesn't work when https is not available.

Additional Information

See email Suggested patch to version 222 with regards to redirection to https:// from user.php by Kristofer Tingdahl

> 1. Thanks for version 222!!
> 2. My system administrator installed cdash 222, and everything went well
> (in general). We did however have a problem as loading user.php
> redirects to https, while our setup does not support that. As our system
> is in a shielded off network, we don't see the need for it.
>
> The current functionality calls redirect_to_https(). My problem is that
> the check that is done at:
>
> $https_check = @fsockopen($_SERVER['HTTP_HOST']);
>
>
> does check the http connection (which works), and not a https
> connection. The attached patch changes that, so the test becomes more
> realistic to what we are about to do. I guess that this is only half
> way, as you may wish the possibility to set the port of the https-call
> than to the current http call. That is not covered by my patch.
>
>
> I can see that in a public system, it is indeed very useful to do this
> redirection. In the light of this, I am proposing a patch (as attached)
> for your consideration.

Tags

No tags attached.

Attached Files

redirect_httpd.diff [^] (505 bytes) 2014-06-27 14:21 [Show Content] [Hide Content]

Index: cdash/common.php
===================================================================
--- cdash/common.php	(revision 3533)
+++ cdash/common.php	(working copy)
@@ -2156,7 +2156,8 @@
     $url = 'https://' . $_SERVER['HTTP_HOST']
                         . $_SERVER['REQUEST_URI'];
 
-    $https_check = @fsockopen($_SERVER['HTTP_HOST']);
+    $testurl = 'https://' . $_SERVER['HTTP_HOST'];
+    $https_check = @fsockopen($testurl);
     if ($https_check)
       {
       header('Location: ' . $url);

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2014-06-27 04:12	Julien Jomier	New Issue
2014-06-27 14:21	Kristofer Tingdahl	File Added: redirect_httpd.diff