[Cdash] [PATCH] Perforce support for CDash

[Pedro Navarro]

>
>
>
> >   $p4command = $CDASH_P4_COMMAND." ".$root." -L en";
>
> >  $raw_output = `$p4command changes $branch@"$fromtime","$totime"
> > 2>&1`;
>
> Can it happen that $root or $CDASH_P4_COMMAND contain spaces or some
> other special characters? I think some quoting might be needed here.
>
>
> 
I guess it could happen, yes, but wouldn't these values come already quoted
from the configuration settings? The user would enter in root a quoted -u
username -c "client name" etc...

Pedro






> -- Igor
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cdash/attachments/20131029/abfeda51/attachment-0003.htm>