<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br><br>
</div>>   $p4command = $CDASH_P4_COMMAND." ".$root." -L en";<br>
<br>
>  $raw_output = `$p4command changes $branch@"$fromtime","$totime"<br>
> 2>&1`;<br>
<br>
Can it happen that $root or $CDASH_P4_COMMAND contain spaces or some<br>
other special characters? I think some quoting might be needed here.<br>
<span class="HOEnZb"><font color="#888888"><br>
<br></font></span></blockquote><div><div class="gmail_default" style="font-family:'trebuchet ms',sans-serif"></div><div class="gmail_default" style="font-family:'trebuchet ms',sans-serif">I guess it could happen, yes, but wouldn't these values come already quoted from the configuration settings? The user would enter in root a quoted -u username -c "client name" etc...</div>
<div class="gmail_default" style="font-family:'trebuchet ms',sans-serif"><br></div><div class="gmail_default" style="font-family:'trebuchet ms',sans-serif">Pedro</div><br></div><div><br></div><div><br></div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
-- Igor<br>
</font></span></blockquote></div><br></div></div>