| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0014990 | CMake | CMake | public | 2014-06-25 10:22 | 2015-01-05 08:38 | ||||
| Reporter | Garth Wells | ||||||||
| Assigned To | Brad King | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | CMake 3.0 | ||||||||
| Target Version | CMake 3.0.1 | Fixed in Version | CMake 3.0.1 | ||||||
| Summary | 0014990: UseSWIG.cmake use wrong filenames for Python | ||||||||
| Description | The change in http://www.cmake.org/Bug/view.php?id=13318 [^] is not correct, since the conditional on line 60 if (CMAKE_SWIG_FLAGS MATCHES "-noproxy") will evaluate to true for the SWIG flag "-noproxydel". The consequence is the module libraries will not be prepended with an underscore and the resulting SWIG code cannot be used. Using if (CMAKE_SWIG_FLAGS MATCHES "-noproxy;") appears to work, but I don't know if this is a robust solution. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0036250) Brad King (manager) 2014-06-25 13:54 |
How about
- if (CMAKE_SWIG_FLAGS MATCHES "-noproxy")
+ if (";${CMAKE_SWIG_FLAGS};" MATCHES ";-noproxy;")? |
|
(0036251) jschueller (developer) 2014-06-25 15:40 |
ok, I see it's already in testing. |
|
(0036252) Brad King (manager) 2014-06-25 15:47 |
Re 0014990:0036251: Yes, the change is here: UseSWIG: Fix check for noproxy flag http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e932ac9c [^] I would appreciate some manual testing because I made the change without testing it and this module is not covered in the test suite. |
|
(0036253) Garth Wells (reporter) 2014-06-25 16:44 |
I can confirm that the proposed fix works for me. Thanks for the quick response. |
|
(0036266) Brad King (manager) 2014-06-27 09:44 |
Great, thanks for reporting back. |
|
(0037573) Robert Maynard (manager) 2015-01-05 08:38 |
Closing resolved issues that have not been updated in more than 4 months. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2014-06-25 10:22 | Garth Wells | New Issue | |
| 2014-06-25 10:44 | Brad King | Assigned To | => jschueller |
| 2014-06-25 10:44 | Brad King | Status | new => assigned |
| 2014-06-25 13:54 | Brad King | Note Added: 0036250 | |
| 2014-06-25 13:54 | Brad King | Target Version | => CMake 3.0.1 |
| 2014-06-25 15:40 | jschueller | Note Added: 0036251 | |
| 2014-06-25 15:46 | Brad King | Assigned To | jschueller => Brad King |
| 2014-06-25 15:47 | Brad King | Note Added: 0036252 | |
| 2014-06-25 16:44 | Garth Wells | Note Added: 0036253 | |
| 2014-06-27 09:44 | Brad King | Note Added: 0036266 | |
| 2014-06-27 09:44 | Brad King | Status | assigned => resolved |
| 2014-06-27 09:44 | Brad King | Resolution | open => fixed |
| 2014-06-27 09:44 | Brad King | Fixed in Version | => CMake 3.0.1 |
| 2015-01-05 08:38 | Robert Maynard | Note Added: 0037573 | |
| 2015-01-05 08:38 | Robert Maynard | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |