MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014990CMakeCMakepublic2014-06-25 10:222015-01-05 08:38
ReporterGarth Wells 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 3.0 
Target VersionCMake 3.0.1Fixed in VersionCMake 3.0.1 
Summary0014990: UseSWIG.cmake use wrong filenames for Python
DescriptionThe change in http://www.cmake.org/Bug/view.php?id=13318 [^] is not correct, since the conditional on line 60

    if (CMAKE_SWIG_FLAGS MATCHES "-noproxy")

will evaluate to true for the SWIG flag "-noproxydel". The consequence is the module libraries will not be prepended with an underscore and the resulting SWIG code cannot be used.

Using

    if (CMAKE_SWIG_FLAGS MATCHES "-noproxy;")

appears to work, but I don't know if this is a robust solution.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-25 10:22Garth WellsNew Issue
2014-06-25 10:44Brad KingAssigned To => jschueller
2014-06-25 10:44Brad KingStatusnew => assigned
2014-06-25 13:54Brad KingNote Added: 0036250
2014-06-25 13:54Brad KingTarget Version => CMake 3.0.1
2014-06-25 15:40jschuellerNote Added: 0036251
2014-06-25 15:46Brad KingAssigned Tojschueller => Brad King
2014-06-25 15:47Brad KingNote Added: 0036252
2014-06-25 16:44Garth WellsNote Added: 0036253
2014-06-27 09:44Brad KingNote Added: 0036266
2014-06-27 09:44Brad KingStatusassigned => resolved
2014-06-27 09:44Brad KingResolutionopen => fixed
2014-06-27 09:44Brad KingFixed in Version => CMake 3.0.1
2015-01-05 08:38Robert MaynardNote Added: 0037573
2015-01-05 08:38Robert MaynardStatusresolved => closed

Notes
(0036250)
Brad King   
2014-06-25 13:54   
How about

-  if (CMAKE_SWIG_FLAGS MATCHES "-noproxy")
+  if (";${CMAKE_SWIG_FLAGS};" MATCHES ";-noproxy;")


?
(0036251)
jschueller   
2014-06-25 15:40   
ok, I see it's already in testing.
(0036252)
Brad King   
2014-06-25 15:47   
Re 0014990:0036251: Yes, the change is here:

 UseSWIG: Fix check for noproxy flag
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e932ac9c [^]

I would appreciate some manual testing because I made the change without testing it and this module is not covered in the test suite.
(0036253)
Garth Wells   
2014-06-25 16:44   
I can confirm that the proposed fix works for me. Thanks for the quick response.
(0036266)
Brad King   
2014-06-27 09:44   
Great, thanks for reporting back.
(0037573)
Robert Maynard   
2015-01-05 08:38   
Closing resolved issues that have not been updated in more than 4 months.