View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011726

CMake

public

2011-01-19 18:04

2012-07-09 06:52

Reporter

James Bigler

Assigned To

James Bigler

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OSX

OS Version

10.5

Product Version

CMake 2.8.4

Target Version

CMake 2.8.7

Fixed in Version

CMake 2.8.7

Summary

0011726: Quotes in add_definitions causes bad command generation

Description

add_definitions(-DFOO="bar")
add_definitions(-Dblah="barf barf")

Will result in:

set(nvcc_flags "-DFOO="bar";-Dblah="barf barf"") which has the quotes all wrong. What I believe needs to be done is to change run_nvcc.cmake to not have the quotes around the definition:

set(nvcc_flags "@nvcc_flags@")

to

set(nvcc_flags @nvcc_flags@)

This probably also means that I'll need to revisit the use of " in all of the variables and make sure that I'm not using where I don't need it.

Tags

No tags attached.

Attached Files

Relationships

has duplicate

0012099

closed

James Bigler

Unable to quote cmd line args to be passed to nvcc

Notes
(0029974) David Cole (manager) 2012-07-09 06:52	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2011-01-19 18:04	James Bigler	New Issue
2011-01-19 18:04	James Bigler	Status	new => assigned
2011-01-19 18:04	James Bigler	Assigned To	=> James Bigler
2011-04-18 15:46	James Bigler	Relationship added	has duplicate 0012099
2011-12-14 23:11	James Bigler	Status	assigned => resolved
2011-12-14 23:11	James Bigler	Fixed in Version	=> CMake 2.8.7
2011-12-14 23:11	James Bigler	Resolution	open => fixed
2011-12-16 17:14	David Cole	Target Version	=> CMake 2.8.7
2012-07-09 06:52	David Cole	Note Added: 0029974
2012-07-09 06:52	David Cole	Status	resolved => closed