MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011726CMakeCMakepublic2011-01-19 18:042012-07-09 06:52
ReporterJames Bigler 
Assigned ToJames Bigler 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOSXOS Version10.5
Product VersionCMake 2.8.4 
Target VersionCMake 2.8.7Fixed in VersionCMake 2.8.7 
Summary0011726: Quotes in add_definitions causes bad command generation
Descriptionadd_definitions(-DFOO="bar")
add_definitions(-Dblah="barf barf")

Will result in:

set(nvcc_flags "-DFOO="bar";-Dblah="barf barf"") which has the quotes all wrong. What I believe needs to be done is to change run_nvcc.cmake to not have the quotes around the definition:

set(nvcc_flags "@nvcc_flags@")

to

set(nvcc_flags @nvcc_flags@)

This probably also means that I'll need to revisit the use of " in all of the variables and make sure that I'm not using where I don't need it.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0012099closed James Bigler Unable to quote cmd line args to be passed to nvcc 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-01-19 18:04James BiglerNew Issue
2011-01-19 18:04James BiglerStatusnew => assigned
2011-01-19 18:04James BiglerAssigned To => James Bigler
2011-04-18 15:46James BiglerRelationship addedhas duplicate 0012099
2011-12-14 23:11James BiglerStatusassigned => resolved
2011-12-14 23:11James BiglerFixed in Version => CMake 2.8.7
2011-12-14 23:11James BiglerResolutionopen => fixed
2011-12-16 17:14David ColeTarget Version => CMake 2.8.7
2012-07-09 06:52David ColeNote Added: 0029974
2012-07-09 06:52David ColeStatusresolved => closed

Notes
(0029974)
David Cole   
2012-07-09 06:52   
Closing resolved issues that have not been updated in more than 4 months.