View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011216

CMake

public

2010-09-08 10:35

2011-06-17 18:20

Reporter

Jörg Riedel

Assigned To

David Cole

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-8

Target Version

CMake 2.8.5

Fixed in Version

CMake 2.8.5

Summary

0011216: Link with /MANIFEST even /manifest:no was set

Description

I comment out
  #SET(CMAKE_START_TEMP_FILE "")
  #SET(CMAKE_END_TEMP_FILE "")
  #SET(CMAKE_VERBOSE_MAKEFILE 1)
in file
  C:\Programme\CMake 2.8\share\cmake-2.8\Modules\Platform\Windows.cmake
and found a /MANIFEST at the end of the link command, although i have set "/manifest:no". At least i found the reason at line 4250 of cmake.cxx where an unconditioned
  linkCommand.push_back("/MANIFEST");
occured. I would suggest to put it in the condition hasManifest as propageted in the attached patch.

Jörg

Tags

No tags attached.

Attached Files

patch0.patch [^] (474 bytes) 2010-09-08 10:35 [Show Content] [Hide Content]

diff --git a/Source/cmake.cxx b/Source/cmake.cxx
index 0f9ef1b..6f0a0da 100644
--- a/Source/cmake.cxx
+++ b/Source/cmake.cxx
@@ -4247,7 +4247,10 @@ int cmake::VisualStudioLinkNonIncremental(std::vector<std::string>& args,
     return -1;
     }
   // Run the link command as given 
-  linkCommand.push_back("/MANIFEST");
+  if(hasManifest)
+    {
+    linkCommand.push_back("/MANIFEST");
+    }
   if(!cmake::RunCommand("LINK", linkCommand, verbose))
     {
     return -1;

Relationships

related to	0011171	closed	Bill Hoffman	Visual Studio 10 solution generation is incorrect
related to	0010704	closed	David Cole	don't GenerateManifest flag (/Manifest:NO) doesn't work with VS 2010

Notes
(0022258) atomicbob (reporter) 2010-09-16 09:31	I patched this and it helped me as well. Additionally you need to set /MANIFEST:NO instead of /manifest:no or the CMake generator will not identify the option and it will try to both use and not use a manifest.

(0025355) David Cole (manager) 2011-02-09 13:07	Fix pushed to 'next' http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fbca267331b1d85f92ea27dfcb9490369c56cf77 [^]

(0026708) David Cole (manager) 2011-06-06 18:25	Closing resolved issues that have not been updated in more than 3 months.

Issue History
Date Modified	Username	Field	Change
2010-09-08 10:35	Jörg Riedel	New Issue
2010-09-08 10:35	Jörg Riedel	File Added: patch0.patch
2010-09-16 09:31	atomicbob	Note Added: 0022258
2011-01-17 16:44	David Cole	Assigned To	=> David Cole
2011-01-17 16:44	David Cole	Status	new => assigned
2011-01-17 16:44	David Cole	Severity	minor => major
2011-02-08 12:15	David Cole	Relationship added	related to 0010704
2011-02-08 12:16	David Cole	Relationship added	related to 0011171
2011-02-09 13:07	David Cole	Note Added: 0025355
2011-02-09 13:07	David Cole	Status	assigned => resolved
2011-02-09 13:07	David Cole	Resolution	open => fixed
2011-06-06 18:25	David Cole	Status	resolved => closed
2011-06-06 18:25	David Cole	Note Added: 0026708
2011-06-17 18:20	David Cole	Fixed in Version	=> CMake 2.8.5
2011-06-17 18:20	David Cole	Target Version	=> CMake 2.8.5