MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011216CMakeCMakepublic2010-09-08 10:352011-06-17 18:20
ReporterJörg Riedel 
Assigned ToDavid Cole 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.5Fixed in VersionCMake 2.8.5 
Summary0011216: Link with /MANIFEST even /manifest:no was set
DescriptionI comment out
  #SET(CMAKE_START_TEMP_FILE "")
  #SET(CMAKE_END_TEMP_FILE "")
  #SET(CMAKE_VERBOSE_MAKEFILE 1)
in file
  C:\Programme\CMake 2.8\share\cmake-2.8\Modules\Platform\Windows.cmake
and found a /MANIFEST at the end of the link command, although i have set "/manifest:no". At least i found the reason at line 4250 of cmake.cxx where an unconditioned
  linkCommand.push_back("/MANIFEST");
occured. I would suggest to put it in the condition hasManifest as propageted in the attached patch.

Jörg
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0011171closed Bill Hoffman Visual Studio 10 solution generation is incorrect 
related to 0010704closed David Cole don't GenerateManifest flag (/Manifest:NO) doesn't work with VS 2010 
Attached Filespatch patch0.patch (474) 2010-09-08 10:35
https://public.kitware.com/Bug/file/3365/patch0.patch
Issue History
Date ModifiedUsernameFieldChange
2010-09-08 10:35Jörg RiedelNew Issue
2010-09-08 10:35Jörg RiedelFile Added: patch0.patch
2010-09-16 09:31atomicbobNote Added: 0022258
2011-01-17 16:44David ColeAssigned To => David Cole
2011-01-17 16:44David ColeStatusnew => assigned
2011-01-17 16:44David ColeSeverityminor => major
2011-02-08 12:15David ColeRelationship addedrelated to 0010704
2011-02-08 12:16David ColeRelationship addedrelated to 0011171
2011-02-09 13:07David ColeNote Added: 0025355
2011-02-09 13:07David ColeStatusassigned => resolved
2011-02-09 13:07David ColeResolutionopen => fixed
2011-06-06 18:25David ColeStatusresolved => closed
2011-06-06 18:25David ColeNote Added: 0026708
2011-06-17 18:20David ColeFixed in Version => CMake 2.8.5
2011-06-17 18:20David ColeTarget Version => CMake 2.8.5

Notes
(0022258)
atomicbob   
2010-09-16 09:31   
I patched this and it helped me as well. Additionally you need to set /MANIFEST:NO instead of /manifest:no or the CMake generator will not identify the option and it will try to both use and not use a manifest.
(0025355)
David Cole   
2011-02-09 13:07   
Fix pushed to 'next'
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fbca267331b1d85f92ea27dfcb9490369c56cf77 [^]
(0026708)
David Cole   
2011-06-06 18:25   
Closing resolved issues that have not been updated in more than 3 months.