View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0010950 | CMake | CMake | public | 2010-07-08 04:55 | 2012-07-09 06:52 | ||||
Reporter | Patrick Spendrin | ||||||||
Assigned To | Brad King | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake-2-8 | ||||||||
Target Version | CMake 2.8.8 | Fixed in Version | CMake 2.8.8 | ||||||
Summary | 0010950: Build error due to wrong bzip2 header | ||||||||
Description | When building cmake from the release branch, build fails if we have a different header from bzip2 in CMAKE_INCLUDE_PATH. CMake uses the included bzip2 though (cmbzip2), so it also should use its own header. To check, build CMake on Windows with attached file in the CMAKE_INCLUDE_PATH | ||||||||
Additional Information | system is windows 7 64bit with 32bit msvc compiler | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | bzlib.h [^] (7,381 bytes) 2010-07-08 04:55 | ||||||||
Relationships | |
Relationships |
Notes | |
(0028238) Rolf Eike Beer (developer) 2012-01-10 13:04 |
I have a patch that basically does this: + IF(BZIP2_INCLUDE_DIR MATCHES "^${CMAKE_SOURCE_DIR}.*") + INCLUDE_DIRECTORIES(BEFORE ${BZIP2_INCLUDE_DIR}) + ELSE() + INCLUDE_DIRECTORIES(${BZIP2_INCLUDE_DIR}) + ENDIF() Both for zlib and bzip2, which Patrick tested. Seems to work. Should I push this? |
(0028241) Rolf Eike Beer (developer) 2012-01-10 15:27 |
Pushed to topic bug10950 on stage, please review. |
(0028257) Rolf Eike Beer (developer) 2012-01-11 03:54 |
Accidentially already merged into next here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=201cf332 [^] |
(0028275) Rolf Eike Beer (developer) 2012-01-12 02:52 |
Seems to work, closing. |
(0028292) Brad King (manager) 2012-01-13 14:15 |
This problem has already been solved in a consistent way for all the other third-party libraries. I'm reverting this fix in favor of another one: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b8813153 [^] |
(0028293) Brad King (manager) 2012-01-13 14:15 |
New fix: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d4a9e334 [^] See commit message for an explanation. |
(0029953) David Cole (manager) 2012-07-09 06:52 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2010-07-08 04:55 | Patrick Spendrin | New Issue | |
2010-07-08 04:55 | Patrick Spendrin | File Added: bzlib.h | |
2010-12-15 10:25 | David Cole | Assigned To | => Bill Hoffman |
2010-12-15 10:25 | David Cole | Status | new => assigned |
2012-01-10 13:04 | Rolf Eike Beer | Note Added: 0028238 | |
2012-01-10 15:27 | Rolf Eike Beer | Note Added: 0028241 | |
2012-01-11 03:54 | Rolf Eike Beer | Note Added: 0028257 | |
2012-01-12 02:52 | Rolf Eike Beer | Note Added: 0028275 | |
2012-01-12 02:52 | Rolf Eike Beer | Assigned To | Bill Hoffman => Rolf Eike Beer |
2012-01-12 02:52 | Rolf Eike Beer | Status | assigned => resolved |
2012-01-12 02:52 | Rolf Eike Beer | Resolution | open => fixed |
2012-01-12 02:52 | Rolf Eike Beer | Fixed in Version | => CMake 2.8.8 |
2012-01-12 02:52 | Rolf Eike Beer | Target Version | => CMake 2.8.8 |
2012-01-13 14:15 | Brad King | Assigned To | Rolf Eike Beer => Brad King |
2012-01-13 14:15 | Brad King | Note Added: 0028292 | |
2012-01-13 14:15 | Brad King | Status | resolved => feedback |
2012-01-13 14:15 | Brad King | Resolution | fixed => reopened |
2012-01-13 14:15 | Brad King | Note Added: 0028293 | |
2012-01-13 14:15 | Brad King | Status | feedback => resolved |
2012-01-13 14:15 | Brad King | Resolution | reopened => fixed |
2012-07-09 06:52 | David Cole | Note Added: 0029953 | |
2012-07-09 06:52 | David Cole | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |