MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010950CMakeCMakepublic2010-07-08 04:552012-07-09 06:52
ReporterPatrick Spendrin 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.8Fixed in VersionCMake 2.8.8 
Summary0010950: Build error due to wrong bzip2 header
DescriptionWhen building cmake from the release branch, build fails if we have a different header from bzip2 in CMAKE_INCLUDE_PATH. CMake uses the included bzip2 though (cmbzip2), so it also should use its own header.

To check, build CMake on Windows with attached file in the CMAKE_INCLUDE_PATH
Steps To Reproduce
Additional Informationsystem is windows 7 64bit with 32bit msvc compiler
TagsNo tags attached.
Relationships
Attached Files? bzlib.h (7,381) 2010-07-08 04:55
https://public.kitware.com/Bug/file/3231/bzlib.h
Issue History
Date ModifiedUsernameFieldChange
2010-07-08 04:55Patrick SpendrinNew Issue
2010-07-08 04:55Patrick SpendrinFile Added: bzlib.h
2010-12-15 10:25David ColeAssigned To => Bill Hoffman
2010-12-15 10:25David ColeStatusnew => assigned
2012-01-10 13:04Rolf Eike BeerNote Added: 0028238
2012-01-10 15:27Rolf Eike BeerNote Added: 0028241
2012-01-11 03:54Rolf Eike BeerNote Added: 0028257
2012-01-12 02:52Rolf Eike BeerNote Added: 0028275
2012-01-12 02:52Rolf Eike BeerAssigned ToBill Hoffman => Rolf Eike Beer
2012-01-12 02:52Rolf Eike BeerStatusassigned => resolved
2012-01-12 02:52Rolf Eike BeerResolutionopen => fixed
2012-01-12 02:52Rolf Eike BeerFixed in Version => CMake 2.8.8
2012-01-12 02:52Rolf Eike BeerTarget Version => CMake 2.8.8
2012-01-13 14:15Brad KingAssigned ToRolf Eike Beer => Brad King
2012-01-13 14:15Brad KingNote Added: 0028292
2012-01-13 14:15Brad KingStatusresolved => feedback
2012-01-13 14:15Brad KingResolutionfixed => reopened
2012-01-13 14:15Brad KingNote Added: 0028293
2012-01-13 14:15Brad KingStatusfeedback => resolved
2012-01-13 14:15Brad KingResolutionreopened => fixed
2012-07-09 06:52David ColeNote Added: 0029953
2012-07-09 06:52David ColeStatusresolved => closed

Notes
(0028238)
Rolf Eike Beer   
2012-01-10 13:04   
I have a patch that basically does this:

+ IF(BZIP2_INCLUDE_DIR MATCHES "^${CMAKE_SOURCE_DIR}.*")
+ INCLUDE_DIRECTORIES(BEFORE ${BZIP2_INCLUDE_DIR})
+ ELSE()
+ INCLUDE_DIRECTORIES(${BZIP2_INCLUDE_DIR})
+ ENDIF()

Both for zlib and bzip2, which Patrick tested. Seems to work. Should I push this?
(0028241)
Rolf Eike Beer   
2012-01-10 15:27   
Pushed to topic bug10950 on stage, please review.
(0028257)
Rolf Eike Beer   
2012-01-11 03:54   
Accidentially already merged into next here:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=201cf332 [^]
(0028275)
Rolf Eike Beer   
2012-01-12 02:52   
Seems to work, closing.
(0028292)
Brad King   
2012-01-13 14:15   
This problem has already been solved in a consistent way for all the other third-party libraries. I'm reverting this fix in favor of another one:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b8813153 [^]
(0028293)
Brad King   
2012-01-13 14:15   
New fix:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d4a9e334 [^]

See commit message for an explanation.
(0029953)
David Cole   
2012-07-09 06:52   
Closing resolved issues that have not been updated in more than 4 months.