View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013486 | CMake | CMake | public | 2012-08-21 17:07 | 2013-03-04 08:38 | ||||
Reporter | Nils Gladitz | ||||||||
Assigned To | Peter Kuemmel | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake 2.8.9 | ||||||||
Target Version | CMake 2.8.10 | Fixed in Version | CMake 2.8.10 | ||||||
Summary | 0013486: COMPILE_FLAGS passed to rc when using Ninja generator | ||||||||
Description | I think this is somewhat similar to 0006834 but with the Ninja generator. I set the COMPILE_FLAGS target property to "/Zi" (I want debug info in release builds for that target 0010636 ). rc also is called with the flag but it does not like it: "invalid option - /z argument missing substitute font name" | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-filter-target-specific-compile-flags-with-language-s.patch [^] (2,239 bytes) 2012-09-18 09:55 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0030731) Peter Kuemmel (developer) 2012-08-21 18:16 |
http://public.kitware.com/pipermail/cmake-commits/2012-August/013269.html [^] |
(0030784) Nils Gladitz (developer) 2012-08-28 03:08 |
The commit does fix my specific issue but the behavior differs from that taken in the makefile generator which seems to filter flags (CMAKE_RC_FLAG_REGEX in CMakeRCInformation.cmake) instead of omitting them. I was thinking of using that behavior to e.g. supply alternate version resources for debug builds. If this is intended or the behavior of the makefile generator is obsolete I don't mind if you close this issue though. |
(0030786) David Cole (manager) 2012-08-28 08:59 |
Yes... Peter, please re-fix this for the ninja generator by honoring CMAKE_RC_FLAG_REGEX like the makefile generator does. We won't take the simple fix that you've already pushed to 'next' into master. We'll wait for the general fix based on this regex variable. Thanks, David |
(0031042) Nils Gladitz (developer) 2012-09-18 09:57 |
I've attached 0001-filter-target-specific-compile-flags-with-language-s.patch (for next) in which I basically copy&pasted the current logic from the makefile generator. |
(0031043) David Cole (manager) 2012-09-18 11:42 |
The attached patch looks good (using the venerable examination-by-eye technique)... Peter, can you make a topic branch, apply this patch, test it, push it and merge it to 'next'? Thanks. |
(0031045) Peter Kuemmel (developer) 2012-09-18 12:08 |
Thanks! I've pushed it to next. |
(0031160) Peter Kuemmel (developer) 2012-10-03 08:43 |
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a1c9c136c33bb9370e5d6c2780817590530c9fbc [^] |
(0032484) Robert Maynard (manager) 2013-03-04 08:38 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-08-21 17:07 | Nils Gladitz | New Issue | |
2012-08-21 18:13 | Peter Kuemmel | Assigned To | => Peter Kuemmel |
2012-08-21 18:13 | Peter Kuemmel | Status | new => assigned |
2012-08-21 18:16 | Peter Kuemmel | Note Added: 0030731 | |
2012-08-21 18:16 | Peter Kuemmel | Status | assigned => resolved |
2012-08-21 18:16 | Peter Kuemmel | Fixed in Version | => CMake 2.8.10 |
2012-08-21 18:16 | Peter Kuemmel | Resolution | open => fixed |
2012-08-28 03:08 | Nils Gladitz | Note Added: 0030784 | |
2012-08-28 03:08 | Nils Gladitz | Status | resolved => feedback |
2012-08-28 03:08 | Nils Gladitz | Resolution | fixed => reopened |
2012-08-28 08:59 | David Cole | Note Added: 0030786 | |
2012-09-18 09:55 | Nils Gladitz | File Added: 0001-filter-target-specific-compile-flags-with-language-s.patch | |
2012-09-18 09:57 | Nils Gladitz | Note Added: 0031042 | |
2012-09-18 09:57 | Nils Gladitz | Status | feedback => assigned |
2012-09-18 11:42 | David Cole | Note Added: 0031043 | |
2012-09-18 12:08 | Peter Kuemmel | Note Added: 0031045 | |
2012-10-03 08:43 | Peter Kuemmel | Note Added: 0031160 | |
2012-10-03 08:43 | Peter Kuemmel | Status | assigned => resolved |
2012-10-03 08:43 | Peter Kuemmel | Resolution | reopened => fixed |
2012-10-24 17:27 | David Cole | Target Version | => CMake 2.8.10 |
2013-03-04 08:38 | Robert Maynard | Note Added: 0032484 | |
2013-03-04 08:38 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |