MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013486CMakeCMakepublic2012-08-21 17:072013-03-04 08:38
ReporterNils Gladitz 
Assigned ToPeter Kuemmel 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.9 
Target VersionCMake 2.8.10Fixed in VersionCMake 2.8.10 
Summary0013486: COMPILE_FLAGS passed to rc when using Ninja generator
DescriptionI think this is somewhat similar to 0006834 but with the Ninja generator.

I set the COMPILE_FLAGS target property to "/Zi" (I want debug info in release builds for that target 0010636 ).

rc also is called with the flag but it does not like it:
"invalid option - /z argument missing substitute font name"

Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-filter-target-specific-compile-flags-with-language-s.patch (2,239) 2012-09-18 09:55
https://public.kitware.com/Bug/file/4484/0001-filter-target-specific-compile-flags-with-language-s.patch
Issue History
Date ModifiedUsernameFieldChange
2012-08-21 17:07Nils GladitzNew Issue
2012-08-21 18:13Peter KuemmelAssigned To => Peter Kuemmel
2012-08-21 18:13Peter KuemmelStatusnew => assigned
2012-08-21 18:16Peter KuemmelNote Added: 0030731
2012-08-21 18:16Peter KuemmelStatusassigned => resolved
2012-08-21 18:16Peter KuemmelFixed in Version => CMake 2.8.10
2012-08-21 18:16Peter KuemmelResolutionopen => fixed
2012-08-28 03:08Nils GladitzNote Added: 0030784
2012-08-28 03:08Nils GladitzStatusresolved => feedback
2012-08-28 03:08Nils GladitzResolutionfixed => reopened
2012-08-28 08:59David ColeNote Added: 0030786
2012-09-18 09:55Nils GladitzFile Added: 0001-filter-target-specific-compile-flags-with-language-s.patch
2012-09-18 09:57Nils GladitzNote Added: 0031042
2012-09-18 09:57Nils GladitzStatusfeedback => assigned
2012-09-18 11:42David ColeNote Added: 0031043
2012-09-18 12:08Peter KuemmelNote Added: 0031045
2012-10-03 08:43Peter KuemmelNote Added: 0031160
2012-10-03 08:43Peter KuemmelStatusassigned => resolved
2012-10-03 08:43Peter KuemmelResolutionreopened => fixed
2012-10-24 17:27David ColeTarget Version => CMake 2.8.10
2013-03-04 08:38Robert MaynardNote Added: 0032484
2013-03-04 08:38Robert MaynardStatusresolved => closed

Notes
(0030731)
Peter Kuemmel   
2012-08-21 18:16   
http://public.kitware.com/pipermail/cmake-commits/2012-August/013269.html [^]
(0030784)
Nils Gladitz   
2012-08-28 03:08   
The commit does fix my specific issue but the behavior differs from that taken in the makefile generator which seems to filter flags (CMAKE_RC_FLAG_REGEX in CMakeRCInformation.cmake) instead of omitting them.

I was thinking of using that behavior to e.g. supply alternate version resources for debug builds.

If this is intended or the behavior of the makefile generator is obsolete I don't mind if you close this issue though.
(0030786)
David Cole   
2012-08-28 08:59   
Yes...

Peter, please re-fix this for the ninja generator by honoring CMAKE_RC_FLAG_REGEX like the makefile generator does.

We won't take the simple fix that you've already pushed to 'next' into master. We'll wait for the general fix based on this regex variable.

Thanks,
David
(0031042)
Nils Gladitz   
2012-09-18 09:57   
I've attached 0001-filter-target-specific-compile-flags-with-language-s.patch (for next) in which I basically copy&pasted the current logic from the makefile generator.
(0031043)
David Cole   
2012-09-18 11:42   
The attached patch looks good (using the venerable examination-by-eye technique)...

Peter, can you make a topic branch, apply this patch, test it, push it and merge it to 'next'?

Thanks.
(0031045)
Peter Kuemmel   
2012-09-18 12:08   
Thanks! I've pushed it to next.
(0031160)
Peter Kuemmel   
2012-10-03 08:43   
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a1c9c136c33bb9370e5d6c2780817590530c9fbc [^]
(0032484)
Robert Maynard   
2013-03-04 08:38   
Closing resolved issues that have not been updated in more than 4 months.