[vtkusers] vtkCellDerivatives

[Martin Genet]

Hi Andy,

I followed the directions, and submitted a patch (19 days ago), but 
haven't heard anything back.

In GitLab the merge requests counter is at 0, but when I try to create a 
new merge request from my commit, it tells the merge request already 
exists. Is it being reviewed somewhere? Thanks!

Martin

On 29/12/2015 13:22, Andy Bauer wrote:
> Hi Martin,
>
> This patch makes sense. It would need a test if you want to get your 
> changes into VTK. The directions for contributing to VTK are at 
> https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/develop.md.
>
> Cheers,
> Andy
>
> On Mon, Dec 28, 2015 at 5:50 PM, Martin Genet 
> <martin.genet at polytechnique.edu 
> <mailto:martin.genet at polytechnique.edu>> wrote:
>
>     Thanks Andy.
>
>     What about simply adding another mode, e.g.
>     SetTensorModeToComputeGreenLagrangeStrain, to the
>     vtkCellDerivatives filter? Would the attached patch make sense?
>
>     Martin
>
>     On 28/12/2015 14:12, Andy Bauer wrote:
>>     Hi Martin,
>>
>>     Changing the name of the SetTensorModeToComputeStrain method to
>>     something else would break backward compatibility which is
>>     generally avoided in VTK. Other options for this include deriving
>>     a class to compute non-linear strain from vtkCellDerivatives if
>>     it shares enough of the algorithm with the linearized version or
>>     maybe just creating a new filter.
>>
>>     Cheers,
>>     Andy
>>
>>     On Sat, Dec 26, 2015 at 4:36 PM, Martin Genet
>>     <martin.genet at polytechnique.edu
>>     <mailto:martin.genet at polytechnique.edu>> wrote:
>>
>>         Dear VTK users:
>>
>>         I realize that the vtkCellDerivatives filter, when
>>         SetTensorModeToComputeStrain is activated, returns the
>>         symmetric part of the gradient of the input vector field,
>>         which is the linearized strain tensor, i.e., not a proper
>>         measure of deformation when large displacements are involved.
>>         Would that make sense to have two different modes,
>>         SetTensorModeToComputeLinearizedStrain or
>>         SetTensorModeToComputeSymmetricGradient, and
>>         SetTensorModeToComputeStrain or
>>         SetTensorModeToComputeGreenLagrangeStrain? Thanks!
>>
>>         Martin
>>         _______________________________________________
>>         Powered by www.kitware.com <http://www.kitware.com>
>>
>>         Visit other Kitware open-source projects at
>>         http://www.kitware.com/opensource/opensource.html
>>
>>         Please keep messages on-topic and check the VTK FAQ at:
>>         http://www.vtk.org/Wiki/VTK_FAQ
>>
>>         Search the list archives at:
>>         http://markmail.org/search/?q=vtkusers
>>
>>         Follow this link to subscribe/unsubscribe:
>>         http://public.kitware.com/mailman/listinfo/vtkusers
>>
>>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtkusers/attachments/20160118/2ce1ba80/attachment.html>