[vtkusers] Re : Java and Mingw, library naming problem

Jerome Robert jeromerobert at gmx.com
Thu Jan 9 11:30:19 EST 2014


Done as http://review.source.kitware.com/#/t/3826/

Jerome

> ----- Message d'origine -----
> De : David E DeMarle
> Envoyés : 09.01.14 15:59
> À : Jerome Robert
> Objet : Re: [vtkusers] Java and Mingw, library naming problem
> 
> Mind sending that patch though gerrit? I know the patch is trivial to
> apply, but submitting it through gerrit vastly simplifies regression
> testing. That makes it much more likely that it will be merged in.
> 
> See: http://www.vtk.org/Wiki/VTK/Git/Develop
> 
> 
> On Thu, Jan 9, 2014 at 9:51 AM, Jerome Robert <jeromerobert at gmx.com> wrote:
> 
> > Hi all,
> >
> > Unless I missed something the following bugs:
> >
> > - http://vtk.org/Bug/view.php?id=10969
> > - http://vtk.org/Bug/view.php?id=7589
> >
> > are still there in vtk 6.1.0rc1 and they could be fixed using the
> > following patch:
> >
> > diff --git a/CMake/vtkJavaWrapping.cmake b/CMake/vtkJavaWrapping.cmake
> > index 8596892..0509cae 100644
> > --- a/CMake/vtkJavaWrapping.cmake
> > +++ b/CMake/vtkJavaWrapping.cmake
> > @@ -41,6 +41,9 @@ function(vtk_add_java_wrapping module_name module_srcs
> > module_hdrs)
> > "${module_srcs};${Kit_JAVA_EXTRA_WRAP_SRCS}")
> >
> > add_library(${module_name}Java SHARED ${ModuleJava_SRCS}
> > ${Kit_JAVA_EXTRA_SRCS})
> > + if(MINGW)
> > + set_target_properties(${module_name}Java PROPERTIES PREFIX "")
> > + endif(MINGW)
> > vtk_target_export(${module_name}Java)
> > if(CMAKE_HAS_TARGET_INCLUDES)
> > set_property(TARGET ${module_name}Java APPEND
> >



More information about the vtkusers mailing list