[vtkusers] Java and Mingw, library naming problem

[David E DeMarle]

Mind sending that patch though gerrit? I know the patch is trivial to
apply, but submitting it through gerrit vastly simplifies regression
testing. That makes it much more likely that it will be merged in.

See: http://www.vtk.org/Wiki/VTK/Git/Develop


David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909


On Thu, Jan 9, 2014 at 9:51 AM, Jerome Robert <jeromerobert at gmx.com> wrote:

> Hi all,
>
> Unless I missed something the following bugs:
>
> - http://vtk.org/Bug/view.php?id=10969
> - http://vtk.org/Bug/view.php?id=7589
>
> are still there in vtk 6.1.0rc1 and they could be fixed using the
> following patch:
>
> diff --git a/CMake/vtkJavaWrapping.cmake b/CMake/vtkJavaWrapping.cmake
> index 8596892..0509cae 100644
> --- a/CMake/vtkJavaWrapping.cmake
> +++ b/CMake/vtkJavaWrapping.cmake
> @@ -41,6 +41,9 @@ function(vtk_add_java_wrapping module_name module_srcs
> module_hdrs)
>      "${module_srcs};${Kit_JAVA_EXTRA_WRAP_SRCS}")
>
>    add_library(${module_name}Java SHARED ${ModuleJava_SRCS}
> ${Kit_JAVA_EXTRA_SRCS})
> +  if(MINGW)
> +    set_target_properties(${module_name}Java PROPERTIES PREFIX "")
> +  endif(MINGW)
>    vtk_target_export(${module_name}Java)
>    if(CMAKE_HAS_TARGET_INCLUDES)
>      set_property(TARGET ${module_name}Java APPEND
>
> Regards,
>
> Jerome
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the VTK FAQ at:
> http://www.vtk.org/Wiki/VTK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtkusers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.vtk.org/pipermail/vtkusers/attachments/20140109/2c44166a/attachment.htm>