[vtkusers] Experimental enhanced wrappers for VTK

David Gobbi david.gobbi at gmail.com
Wed May 26 17:46:02 EDT 2010


Hi Keith,

Thanks for doing this!  I was not looking forward to doing the
clean-up work myself... when I started it never occurred to me to
create a branch, my plan was to eventually re-base my changes on the
VTK master.

There are just two minor changes that I can squeeze in over the next
two days, and I will email you when they are done.  After that, the
sooner that the branch can be merged into master, the better.  In
order for the special-type wrapping to be fully realized, most (or
all) of the BTX's will have to be removed from the code.  A change
that big will probably be easier to do in the master than to merge in
from a branch.

I've already tested VTK (with python, tcl, and java) without BTX/ETX.
The Tcl and Java wrappers compiled and tested cleanly, and so did
Python after I did some small fixes to the way that it does special
type wrapping.  It is these python fixes that I need to commit before
the merge.

There are other changes that I'm planning for the Python wrappers
(enums, etc) but for them I'd prefer to wait until after the merge.
I'll put together a wiki page so that they can be reviewed.

   David


   David





On Wed, May 26, 2010 at 2:39 PM, Keith Fieldhouse
<keith.fieldhouse at kitware.com> wrote:
> David
> I've been spending some time looking at your Wrapping work.  It appears that
> your git tree was built with a mixture of rebasing and merging which
> resulted in a somewhat wonky commit history (duplicated commits interspersed
> with commits coming from VTK master).
> In order to get a clean topic branch that will be a little easier for folks
> here to look at (and to eventually merge with master) I spent a  bit of time
> untangling your history (mostly by examining parentage and looking at commit
> subjects).  In the end, by cherry picking the right commits in what I
> considered the "right" order I was able to build a clean topic branch with
> no conflicts.  Once I had that, I rebased it against master (as of this
> afternoon sometime when I did it).  The result can be found in
> git://github.com/keith-fieldhouse/VTK.git
> As the topic branch Gobbi/Wrapping.
> The result builds and the tests run so I believe that I've built a a
> representative branch from your work.
> If you plan on doing additional work on this, would it be possible for you
> to grab this topic branch and work on that (without rebasing or merging for
> now)?    That way we'll have a clean topic branch  for an eventual merge to
> "Next" when we switch to branchy development for VTK.  Or if branchy
> development comes later, this clean topic branch will be easier to rebase as
> well.
> Thanks again for your work on this.
> Keith
> --
> Keith Fieldhouse
> R&D Engineer, Kitware Inc.
> (518) 836-2190
>
>
>
>



More information about the vtkusers mailing list