[vtkusers] Dashboard no longer shows locally modified files

[Kevin H. Hobbs]

I have a local modification to Rendering/vtkOpenGLRenderWindow.cxx on
one of my workstations.

This machine runs the nightly Dashboard.

CDash used to report that I had the local modifications.

As of the 18th it stopped :

http://www.cdash.org/CDash/buildSummary.php?buildid=338927


Last night's LastUpdate_20090529-0200.log lists the file as modified.

M Rendering/vtkOpenGLRenderWindow.cxx

The same goes for ParaView.

The change keeps saved images of the scene from being garbled.

Index: Rendering/vtkOpenGLRenderWindow.cxx                           
===================================================================  
RCS file: /cvsroot/VTK/VTK/Rendering/vtkOpenGLRenderWindow.cxx,v     
retrieving revision 1.104                                            
diff -u -8 -p -r1.104 vtkOpenGLRenderWindow.cxx                      
--- Rendering/vtkOpenGLRenderWindow.cxx 4 Dec 2008 19:05:20 -0000       1.104
+++ Rendering/vtkOpenGLRenderWindow.cxx 29 May 2009 16:31:50 -0000           
@@ -502,17 +502,17 @@ int vtkOpenGLRenderWindow::GetPixelData(               
     }                                                                       
   else                                                                      
     {                                                                       
     glReadBuffer(static_cast<GLenum>(this->GetBackLeftBuffer()));           
     }                                                                       
                                                                             
   glDisable( GL_SCISSOR_TEST );                                             
                                                                             
-#if defined(sparc) && !defined(GL_VERSION_1_2)
+//#if defined(sparc) && !defined(GL_VERSION_1_2)
   // We need to read the image data one row at a time and convert it
   // from RGBA to RGB to get around a bug in Sun OpenGL 1.1
   long    xloop, yloop;
   unsigned char *buffer;
   unsigned char *p_data = NULL;

   buffer = new unsigned char [4*(x_hi - x_low + 1)];
   p_data = data;
@@ -525,30 +525,30 @@ int vtkOpenGLRenderWindow::GetPixelData(
       {
       *p_data = buffer[xloop*4]; p_data++;
       *p_data = buffer[xloop*4+1]; p_data++;
       *p_data = buffer[xloop*4+2]; p_data++;
       }
     }

   delete [] buffer;
-#else
+/*#else
   // If the Sun bug is ever fixed, then we could use the following
   // technique which provides a vast speed improvement on the SGI

   // Turn of texturing in case it is on - some drivers have a problem
   // getting / setting pixels with texturing enabled.
   glDisable( GL_TEXTURE_2D );

   // Calling pack alignment ensures that we can grab the any size window
   glPixelStorei( GL_PACK_ALIGNMENT, 1 );
   glReadPixels(x_low, y_low, x_hi-x_low+1, y_hi-y_low+1, GL_RGB,
                GL_UNSIGNED_BYTE, data);
 #endif
-
+*/
   if (glGetError() != GL_NO_ERROR)
     {
     return VTK_ERROR;
     }
   else
     {
     return VTK_OK;
     }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://www.vtk.org/pipermail/vtkusers/attachments/20090529/1870ba26/attachment.pgp>