[vtkusers] vtkAbaqusElementModel and vtkAbaqusInputDeckReader

[Budd Hirons]

Mathieu,

I have incorporated your switch for #1, as for number 2, I see the 
problem, and have cleaned out unnecessary function args for those two 
and a couple of other function calls.

Please note the attached patch.  This is a diff -u3 output like you 
generated before, this patch is against the *original* .cxx files I 
emailed you this morning and includes your earlier patch as well as the 
changes we have discussed.

Please let me know if there are any compile issues left, thanks for your 
help.

Cheers,
Budd.

Mathieu Malaterre wrote:
> Budd,
> 
>     Thanks for the feedback.
>     For #1, sorry my mistake, how about then:
> 
>      if( iter->c_str()[0] == *(star) )
> 
>    Looks like my old gcc 2.95 had trouble casting the expression, 
> otherwise.
> 
>     For #2, it just means I don't know what those variables are for, but 
> the compiler complains that they are not used. Another way to get rid of 
> this compiler warning is to remove the var from the function declaration.
> 
> Mathieu
> 
> Budd Hirons wrote:
> 
>> Thanks for the patch Mathieu, I have two questions...
>>
>> 1. lines 110-11 of your patch for vtkAbaqusInputDeckReader.cxx
>>
>> -        if( (*iter)[0] == *(star) )
>> +        if( *(*iter) == *(star) )
>>
>> iter is an iterator for a vector of vtkStdString objects, and this is 
>> meant to compare the first character.
>>
>> this is the error I get on Windows:
>>
>> Compiling...
>> vtkAbaqusInputDeckReader.cxx
>> C:\Shared\Source\vtkLocal\vtkAbaqusInputDeckReader.cxx(486) : error 
>> C2100: illegal indirection
>> C:\Shared\Source\vtkLocal\vtkAbaqusInputDeckReader.cxx(486) : error 
>> C2678: binary '==' : no operator defined which takes a left-hand 
>> operand of type 'class vtkStdString' (or there is no acceptable 
>> conversion)
>> Error executing cl.exe.
>>
>> 2. line 66 of your patch for the same file adds this:
>>
>> +  (void)inp;
>>
>> and line 82 does this:
>>
>> +  (void)size;
>>
>> These don't break anything, so it doens't matter to me, but I am 
>> curious as to why this is added here?
>>
>>
>> Otherwise, everthing else seems fine, sensible and appropriate.
>>
>> Cheers,
>> Budd.
> 
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: abaqus_cxx.patch
URL: <http://www.vtk.org/pipermail/vtkusers/attachments/20050623/ebf9f288/attachment.txt>