[vtkusers] Some trivial bugs with vtk.

Prabhu Ramachandran prabhu at aero.iitm.ernet.in
Thu Oct 26 01:42:22 EDT 2000


hi,

	Here are some trivial bugs I found today with vtk.  They
should be easy to fix.

1) Why are so many of the .cxx/.h files and other text files (in the
cvs tree) executable?

2) Why do we need executables/libraries in the cvs tree.  The pcmaker
directory has the following files:

$ ls -l *.exe
-rwxr-xr-x    1 prabhu   prabhu     905273 Oct 22 01:23 pcmaker.exe*
-rwxr-xr-x    1 prabhu   prabhu     147456 Apr 28  2000 vtkHTML.exe*
-rwxr-xr-x    1 prabhu   prabhu     147456 Jul 12 21:12 vtkParseJava.exe*
-rwxr-xr-x    1 prabhu   prabhu     155648 Jul 12 21:12 vtkWrapJava.exe*
-rwxr-xr-x    1 prabhu   prabhu     154624 Sep 30 00:07 vtkWrapPython.exe*
-rwxr-xr-x    1 prabhu   prabhu     172032 Oct 22 01:24 vtkWrapTcl.exe*
$
	Why should these exist in the cvs tree??  Why do you also need
to distribute the tcl82/tk82 libs with VTK?

3) Why do the Makefiles insist on installing the libraries with the
execute bit on?  For instance in Kits.make

----
install_python: install build_python
        @echo "Installing libVTK${ME}Python${SHLIB_SUFFIX}"
        ${INSTALL} -m 755 libVTK${ME}Python${SHLIB_SUFFIX} $(LIB_INSTALL_DIR)/li
bVTK${ME}Python${SHLIB_SUFFIX}
---
	And similar things elsewhere.  Shouldnt this be ${INSTALL} -m
644 instead?

4) A small consistency question.  In vtkViewport.h there is a function
to set the background color.  Get/Set Backgroud().  Shouldn't this
function be called Get/Set BackgroundColor instead?  Every other
Get/Set*Color function has a "Color" at the end.


	Sorry if this sounds like nitpicking, but I thought these were
worth mentioning and might be of some use.

thanks,
prabhu




More information about the vtkusers mailing list