[vtk-developers] help wih 3 cppcheck warnings (vtkCell3D.cxx & vtkExtractSelectedIds.cxx)

[David E DeMarle]

I'll fix the extract ids filter.

On Wed, Sep 19, 2018, 10:04 PM Sean McBride <sean at rogue-research.com> wrote:

> Hi all,
>
> Anyone familiar with these 2 classes want to tackle these 3 cppcheck
> warnings?  They are not false positives, there is definite code smell:
>
> oppositeExpression,Common/DataModel/vtkCell3D.cxx:122,style,Opposite
> expression on both sides of '||'.
>
> identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:358,warning,Identical
> inner 'if' condition is always true.
>
> identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:507,warning,Identical
> inner 'if' condition is always true.
>
> Cheers,
>
> Sean
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> https://public.kitware.com/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://public.kitware.com/pipermail/vtk-developers/attachments/20180920/b09aa0e7/attachment.html>