<div dir="auto">I'll fix the extract ids filter. </div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 19, 2018, 10:04 PM Sean McBride <<a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
Anyone familiar with these 2 classes want to tackle these 3 cppcheck warnings?  They are not false positives, there is definite code smell:<br>
<br>
oppositeExpression,Common/DataModel/vtkCell3D.cxx:122,style,Opposite expression on both sides of '||'.<br>
<br>
identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:358,warning,Identical inner 'if' condition is always true.<br>
<br>
identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:507,warning,Identical inner 'if' condition is always true.<br>
<br>
Cheers,<br>
<br>
Sean<br>
<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="https://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer noreferrer" target="_blank">https://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
<br>
</blockquote></div>