[vtk-developers] help with cppcheck duplInheritedMember warnings

[Andy Bauer]

Hi Sean,

Thanks for looking at this. I'll take a look at Filters/FlowPaths/
vtkAbstractInterpolatedVelocityField.h.

Best,
Andy

On Thu, Jan 19, 2017 at 10:13 PM, Sean McBride <sean at rogue-research.com>
wrote:

> Hi all,
>
> I've deliberately un-suppressed cppcheck's duplInheritedMember warning and
> now we have 24 warnings here:
>
> <https://open.cdash.org/viewBuildError.php?type=1&buildid=4730716>
>
> The warning is telling us that various classes have ivars with the same
> name as an ivar in their superclass. This is a pretty bad code smell IMNSHO.
>
> But it takes someone who knows the classes well to decide on the best
> fix...
>
> The warnings are:
>
> Charts/Core/vtkPlot3D.h:152: warning: The class 'vtkPlotSurface' defines
> member variable with name 'Colors' also defined in its parent class
> 'vtkPlot3D'.
>
> Charts/Core/vtkChartMatrix.h:155: warning: The class
> 'vtkScatterPlotMatrix' defines member variable with name 'Private' also
> defined in its parent class 'vtkChartMatrix'.
>
> Common/DataModel/vtkPlanes.h:129: warning: The class
> 'vtkPlanesIntersection' defines member variable with name 'Plane' also
> defined in its parent class 'vtkPlanes'.
>
> Common/DataModel/vtkGenericCellTessellator.h:211: warning: The class
> 'vtkSimpleCellTessellator' defines member variable with name 'DataSet' also
> defined in its parent class 'vtkGenericCellTessellator'.
>
> Common/ExecutionModel/vtkStreamingDemandDrivenPipeline.h:349: warning:
> The class 'vtkCompositeDataPipeline' defines member variable with name
> 'UpdateExtentRequest' also defined in its parent class '
> vtkStreamingDemandDrivenPipeline'.
>
> Filters/FlowPaths/vtkAbstractInterpolatedVelocityField.h:211: warning:
> The class 'vtkCompositeInterpolatedVelocityField' defines member variable
> with name 'TOLERANCE_SCALE' also defined in its parent class '
> vtkAbstractInterpolatedVelocityField'.
>
> IO/SQL/vtkTableToDatabaseWriter.h:75: warning: The class
> 'vtkTableToSQLiteWriter' defines member variable with name 'Input' also
> defined in its parent class 'vtkTableToDatabaseWriter'.
>
> Imaging/Core/vtkImageReslice.h:510: warning: The class 'vtkImageResample'
> defines member variable with name 'OutputSpacing' also defined in its
> parent class 'vtkImageReslice'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:213: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'Modifier' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:233: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'P1World' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:234: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'P2World' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:235: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'P3World' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:236: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'P4World' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:237: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'P21World' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:238: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'P43World' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:239: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'T21' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:240: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'T43' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:241: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'CenterWorld' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Interaction/Widgets/vtkBiDimensionalRepresentation.h:242: warning: The
> class 'vtkBiDimensionalRepresentation2D' defines member variable with
> name 'StartEventPositionWorld' also defined in its parent class '
> vtkBiDimensionalRepresentation'.
>
> Rendering/Core/vtkColorTransferFunction.h:398: warning: The class '
> vtkDiscretizableColorTransferFunction' defines member variable with name
> 'BuildTime' also defined in its parent class 'vtkColorTransferFunction'.
>
> Rendering/OpenGL/vtkStandardPolyDataPainter.h:86: warning: The class '
> vtkHardwareSelectionPolyDataPainter' defines member variable with name
> 'TotalCells' also defined in its parent class 'vtkStandardPolyDataPainter'.
>
> Rendering/OpenGL/vtkXRenderWindowInteractor.h:198: warning: The class 'vtkXRenderWindowTclInteractor'
> defines member variable with name 'Internal' also defined in its parent
> class 'vtkXRenderWindowInteractor'.
>
> Views/Infovis/vtkRenderView.h:289: warning: The class
> 'vtkGraphLayoutView' defines member variable with name 'Interacting' also
> defined in its parent class 'vtkRenderView'.
>
> Views/Infovis/vtkRenderedRepresentation.h:96: warning: The class '
> vtkRenderedTreeAreaRepresentation' defines member variable with name
> 'Implementation' also defined in its parent class
> 'vtkRenderedRepresentation'.
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/
> opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20170120/0573ae45/attachment.html>