<div dir="ltr"><div><div><div>Hi Sean,<br><br></div>Thanks for looking at this. I'll take a look at Filters/FlowPaths/<wbr>vtkAbstractInterpolatedVelocit<wbr>yField.h. <br><br></div>Best,<br></div>Andy<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 19, 2017 at 10:13 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com" target="_blank">sean@rogue-research.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
I've deliberately un-suppressed cppcheck's duplInheritedMember warning and now we have 24 warnings here:<br>
<br>
<<a href="https://open.cdash.org/viewBuildError.php?type=1&buildid=4730716" rel="noreferrer" target="_blank">https://open.cdash.org/<wbr>viewBuildError.php?type=1&<wbr>buildid=4730716</a>><br>
<br>
The warning is telling us that various classes have ivars with the same name as an ivar in their superclass. This is a pretty bad code smell IMNSHO.<br>
<br>
But it takes someone who knows the classes well to decide on the best fix...<br>
<br>
The warnings are:<br>
<br>
Charts/Core/vtkPlot3D.h:152: warning: The class 'vtkPlotSurface' defines member variable with name 'Colors' also defined in its parent class 'vtkPlot3D'.<br>
<br>
Charts/Core/vtkChartMatrix.h:<wbr>155: warning: The class 'vtkScatterPlotMatrix' defines member variable with name 'Private' also defined in its parent class 'vtkChartMatrix'.<br>
<br>
Common/DataModel/vtkPlanes.h:<wbr>129: warning: The class 'vtkPlanesIntersection' defines member variable with name 'Plane' also defined in its parent class 'vtkPlanes'.<br>
<br>
Common/DataModel/<wbr>vtkGenericCellTessellator.h:<wbr>211: warning: The class 'vtkSimpleCellTessellator' defines member variable with name 'DataSet' also defined in its parent class 'vtkGenericCellTessellator'.<br>
<br>
Common/ExecutionModel/<wbr>vtkStreamingDemandDrivenPipeli<wbr>ne.h:349: warning: The class 'vtkCompositeDataPipeline' defines member variable with name 'UpdateExtentRequest' also defined in its parent class '<wbr>vtkStreamingDemandDrivenPipeli<wbr>ne'.<br>
<br>
Filters/FlowPaths/<wbr>vtkAbstractInterpolatedVelocit<wbr>yField.h:211: warning: The class '<wbr>vtkCompositeInterpolatedVeloci<wbr>tyField' defines member variable with name 'TOLERANCE_SCALE' also defined in its parent class '<wbr>vtkAbstractInterpolatedVelocit<wbr>yField'.<br>
<br>
IO/SQL/<wbr>vtkTableToDatabaseWriter.h:75: warning: The class 'vtkTableToSQLiteWriter' defines member variable with name 'Input' also defined in its parent class 'vtkTableToDatabaseWriter'.<br>
<br>
Imaging/Core/vtkImageReslice.<wbr>h:510: warning: The class 'vtkImageResample' defines member variable with name 'OutputSpacing' also defined in its parent class 'vtkImageReslice'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:213: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'Modifier' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:233: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'P1World' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:234: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'P2World' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:235: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'P3World' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:236: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'P4World' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:237: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'P21World' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:238: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'P43World' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:239: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'T21' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:240: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'T43' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:241: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'CenterWorld' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Interaction/Widgets/<wbr>vtkBiDimensionalRepresentation<wbr>.h:242: warning: The class '<wbr>vtkBiDimensionalRepresentation<wbr>2D' defines member variable with name 'StartEventPositionWorld' also defined in its parent class '<wbr>vtkBiDimensionalRepresentation<wbr>'.<br>
<br>
Rendering/Core/<wbr>vtkColorTransferFunction.h:<wbr>398: warning: The class '<wbr>vtkDiscretizableColorTransferF<wbr>unction' defines member variable with name 'BuildTime' also defined in its parent class 'vtkColorTransferFunction'.<br>
<br>
Rendering/OpenGL/<wbr>vtkStandardPolyDataPainter.h:<wbr>86: warning: The class '<wbr>vtkHardwareSelectionPolyDataPa<wbr>inter' defines member variable with name 'TotalCells' also defined in its parent class 'vtkStandardPolyDataPainter'.<br>
<br>
Rendering/OpenGL/<wbr>vtkXRenderWindowInteractor.h:<wbr>198: warning: The class '<wbr>vtkXRenderWindowTclInteractor' defines member variable with name 'Internal' also defined in its parent class 'vtkXRenderWindowInteractor'.<br>
<br>
Views/Infovis/vtkRenderView.h:<wbr>289: warning: The class 'vtkGraphLayoutView' defines member variable with name 'Interacting' also defined in its parent class 'vtkRenderView'.<br>
<br>
Views/Infovis/<wbr>vtkRenderedRepresentation.h:<wbr>96: warning: The class '<wbr>vtkRenderedTreeAreaRepresentat<wbr>ion' defines member variable with name 'Implementation' also defined in its parent class 'vtkRenderedRepresentation'.<br>
<br>
<br>
______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/vtk-<wbr>developers</a><br>
<br>
</blockquote></div><br></div>