[vtk-developers] Anyone know Python? (and can look at dashboard failure)

[Shawn Waldon]

Hi all,

I talked with Berk about this one this morning and I have a MR that fixes
it the bad comparisons [1].  Apparently I missed that the file also used
xrange, so I just pushed an update to remove those.

Shawn

[1]: https://gitlab.kitware.com/vtk/vtk/merge_requests/2384

On Tue, Jan 17, 2017 at 4:21 PM, Andrew Maclean <andrew.amaclean at gmail.com>
wrote:

> Nice, thanks for pointing this out.
>
> Andrew
>
> ---------- Forwarded message ----------
>> From: Stuart Axon <stuaxo2 at yahoo.com>
>> To: "andrew.amaclean at gmail.com" <andrew.amaclean at gmail.com>, VTK
>> Developers <vtk-developers at vtk.org>, Ken Martin <ken.martin at kitware.com>
>> Cc:
>> Date: Tue, 17 Jan 2017 15:53:45 +0000 (UTC)
>> Subject: Re: [vtk-developers] Anyone know Python? (and can look at a
>> dashboard failure)
>> if type(axis) == type(None) or axis > 0:
>>
>> is not as idiomatic as:
>>
>> if axis is None or axis > 0:
>>
>> But this is totally fine too:
>>
>> if axis and axis > 0:
>>
>>
>> S++
>>
>>
>> On Sunday, January 15, 2017 9:50 PM, Andrew Maclean <
>> andrew.amaclean at gmail.com> wrote:
>>
>>
>>
>> Sorry Ken I forgot to include you.
>>
>> I can't test it as I don't have MPI installed but there are two
>> approaches:
>> 1:
>> if axis and axis > 0:
>> This should work. It seems to me that you want to return the result of
>> impl.op() if axis > 0.
>> 2:
>> If the *or* is correct then you can use:
>> if type(axis) == type(None) or axis > 0:
>>
>> On Mon, Jan 16, 2017 at 8:41 AM, Andrew Maclean <
>> andrew.amaclean at gmail.com> wrote:
>>
>> Unfortunately I don't have MPI installed so I can't test it.
>>
>> On Mon, Jan 16, 2017 at 8:17 AM, Andrew Maclean <
>> andrew.amaclean at gmail.com> wrote:
>>
>> Hi Ken,
>>    I think the fix is this:
>>
>> if axis and axis > 0:
>> This should work. It seems to me that you want to return the result of
>> impl.op() if axis > 0.
>>
>> Regards
>>    Andrew
>>
>> ---------- Forwarded message ----------
>> From: Ken Martin <ken.martin at kitware.com>
>> To: VTK Developers <vtk-developers at vtk.org>
>> Cc:
>> Date: Sat, 14 Jan 2017 17:07:17 -0500
>> Subject: [vtk-developers] Anyone know Python? (and can look at a
>> dashboard failure)
>>
>> The buildbots are pretty clean except we have one failing test on eeloo
>> related to Python
>>
>> https://open.cdash.org/testDet ails.php?test=516490674&build= 4724245
>> <https://open.cdash.org/testDetails.php?test=516490674&build=4724245>
>>
>> It fails comparing a None to an int while other machines running that
>> test pass. So I suspect it has something to do with the
>> build/version/settings of python on it. I tried fixing the None int
>> comparison but then it moved to a different failure, once again reminding
>> me that python still lacks the elegant grace of Visual Basic (I am so
>> baiting python users with that one)
>>
>> https://gitlab.kitware.com/vtk /vtk/merge_requests/2359
>> <https://gitlab.kitware.com/vtk/vtk/merge_requests/2359>
>>
>> Anyone have a thought on what the right fix is?
>>
>> Thanks!
>> Ken
>>
>> --
>> Ken Martin PhD
>> Chairman & CFO
>> Kitware Inc.
>> 28 Corporate Drive
>> Clifton Park NY 12065
>> 518 371 3971
>>
>> This communication, including all attachments, contains confidential and
>> legally privileged information, and it is intended only for the use of the
>> addressee.  Access to this email by anyone else is unauthorized. If you are
>> not the intended recipient, any disclosure, copying, distribution or any
>> action taken in reliance on it is prohibited and may be unlawful. If you
>> received this communication in error please notify us immediately and
>> destroy the original message.  Thank you.
>>
>> ______________________________ _________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensou
>> rce/opensource.html <http://www.kitware.com/opensource/opensource.html>
>>
>> Search the list archives at: http://markmail.org/search/?q=
>> vtk-developers <http://markmail.org/search/?q=vtk-developers>
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mail man/listinfo/vtk-developers
>> <http://public.kitware.com/mailman/listinfo/vtk-developers>
>>
>>
>>
>>
>> --
>> ______________________________ _____________
>> Andrew J. P. Maclean
>>
>> ______________________________ _____________
>>
>>
>>
>>
>> --
>> ______________________________ _____________
>> Andrew J. P. Maclean
>>
>> ______________________________ _____________
>>
>>
>>
>>
>> --
>> ______________________________ _____________
>> Andrew J. P. Maclean
>>
>> ______________________________ _____________
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
>>
>>
>>
> --
> ___________________________________________
> Andrew J. P. Maclean
>
> ___________________________________________
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensou
> rce/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20170117/47973d7f/attachment.html>