<div dir="ltr"><div><div>Hi all,<br><br></div>I talked with Berk about this one this morning and I have a MR that fixes it the bad comparisons [1]. Apparently I missed that the file also used xrange, so I just pushed an update to remove those.<br><br></div>Shawn<br><br>[1]: <a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/2384" target="_blank">https://gitlab.kitware.com/<wbr>vtk/vtk/merge_requests/2384</a><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 17, 2017 at 4:21 PM, Andrew Maclean <span dir="ltr"><<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Nice, thanks for pointing this out.<div><br></div><div>Andrew</div><div class="gmail_extra"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---------- Forwarded message ----------<br>From: Stuart Axon <<a href="mailto:stuaxo2@yahoo.com" target="_blank">stuaxo2@yahoo.com</a>><br>To: "<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a><wbr>" <<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>>, VTK Developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>>, Ken Martin <<a href="mailto:ken.martin@kitware.com" target="_blank">ken.martin@kitware.com</a>><br>Cc: <br>Date: Tue, 17 Jan 2017 15:53:45 +0000 (UTC)<br>Subject: Re: [vtk-developers] Anyone know Python? (and can look at a dashboard failure)<br><div><div style="color:#000;background-color:#fff;font-family:HelveticaNeue,Helvetica Neue,Helvetica,Arial,Lucida Grande,sans-serif;font-size:16px"><div id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16905"></div><div id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16915"><code id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16916">if type(axis) == type(None) or axis > 0:</code></div><div id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16917"><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16958"><br id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16918" clear="none"></div><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16957">is not as idiomatic as:</div><br><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17112"><code id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17073">if axis is None or axis > 0:</code><span id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17074"> </span></div><div dir="ltr"><br></div><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17022">But this is totally fine too:<br></div><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17038"><br></div><div id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17029"><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17037"><code id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17030">if axis and axis > 0:</code><span id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17031"> <br id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_17032"></span></div></div><div dir="ltr" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16956"><br id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16918" clear="none"></div></div><div id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16812"> </div><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075signature" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yui_3_16_0_ym19_1_1484664971332_16919">S++</div> <div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075qtdSeparateBR"><br><br></div><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yahoo_quoted" style="display:block"> <div style="font-family:HelveticaNeue,Helvetica Neue,Helvetica,Arial,Lucida Grande,sans-serif;font-size:16px"> <div style="font-family:HelveticaNeue,Helvetica Neue,Helvetica,Arial,Lucida Grande,sans-serif;font-size:16px"> <div dir="ltr"><font size="2" face="Arial"> On Sunday, January 15, 2017 9:50 PM, Andrew Maclean <<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>> wrote:<br></font></div> <blockquote style="border-left:2px solid rgb(16,16,255);margin-left:5px;margin-top:5px;padding-left:5px"> <br><br> <div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075y_msg_container"><div id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601"><div><div dir="ltr">Sorry Ken I forgot to include you.<div><br clear="none"></div><div>I can't test it as I don't have MPI installed but there are two approaches:</div><div>1:<div><code>if axis and axis > 0:</code> </div><div>This should work. It seems to me that you want to return the result of impl.op() if axis > 0.</div>2:<div>If the <b style="margin-top:0px">or</b> is correct then you can use:</div><div><code>if type(axis) == type(None) or axis > 0:</code></div></div><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_extra"><br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601yqt4739705124" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601yqt88464"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_quote">On Mon, Jan 16, 2017 at 8:41 AM, Andrew Maclean <span dir="ltr"><<a rel="nofollow" shape="rect" href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br clear="none"><blockquote class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Unfortunately I don't have MPI installed so I can't test it.</div><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345HOEnZb"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345h5"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_extra"><br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_quote">On Mon, Jan 16, 2017 at 8:17 AM, Andrew Maclean <span dir="ltr"><<a rel="nofollow" shape="rect" href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>></span> wrote:<br clear="none"><blockquote class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Ken,<div> I think the fix is this:</div><div><br clear="none"></div><div><code>if axis and axis > 0:</code><span> </span></div>This should work. It seems to me that you want to return the result of impl.op() if axis > 0.<br clear="none"><br clear="none">Regards<br clear="none"> Andrew<div><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_extra"><br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_quote"><blockquote class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---------- Forwarded message ----------<br clear="none">From: Ken Martin <<a rel="nofollow" shape="rect" href="mailto:ken.martin@kitware.com" target="_blank">ken.martin@kitware.com</a>><br clear="none">To: VTK Developers <<a rel="nofollow" shape="rect" href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br clear="none">Cc: <br clear="none">Date: Sat, 14 Jan 2017 17:07:17 -0500<br clear="none">Subject: [vtk-developers] Anyone know Python? (and can look at a dashboard failure)<br clear="none"><div dir="ltr"><div><br clear="none"></div><div>The buildbots are pretty clean except we have one failing test on eeloo related to Python<br clear="none"></div><div><br clear="none"></div><div><a rel="nofollow" shape="rect" href="https://open.cdash.org/testDetails.php?test=516490674&build=4724245" target="_blank">https://open.cdash.org/testDet ails.php?test=516490674&build= 4724245</a></div><div><br clear="none"></div><div>It fails comparing a None to an int while other machines running that test pass. So I suspect it has something to do with the build/version/settings of python on it. I tried fixing the None int comparison but then it moved to a different failure, once again reminding me that python still lacks the elegant grace of Visual Basic (I am so baiting python users with that one)</div><div><br clear="none"></div><div><a rel="nofollow" shape="rect" href="https://gitlab.kitware.com/vtk/vtk/merge_requests/2359" target="_blank">https://gitlab.kitware.com/vtk /vtk/merge_requests/2359</a></div><div><br clear="none"></div><div>Anyone have a thought on what the right fix is?</div><div><br clear="none"></div><div>Thanks!</div><div>Ken<br clear="all"><div><br clear="none"></div>-- <br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345m_8577259833820698672m_-2281178649223897747gmail-m_-1086856794735311128gmail_signature">Ken Martin PhD<div>Chairman & CFO<br clear="none">Kitware Inc.<br clear="none">28 Corporate Drive<br clear="none">Clifton Park NY 12065<br clear="none"><a rel="nofollow" shape="rect">518 371 3971</a><div><br clear="none"></div><div><span style="font-size:10pt;font-family:tahoma,sans-serif">This communication,
including all attachments, contains confidential and legally privileged
information, and it is intended only for the use of the addressee. Access to this email by anyone else is
unauthorized. If you are not the intended recipient, any disclosure, copying,
distribution or any action taken in reliance on it is prohibited and may be
unlawful. If you received this communication in error please notify us
immediately and destroy the original message.
Thank you.</span></div></div></div>
</div></div>
<br clear="none">______________________________ _________________<br clear="none">
Powered by <a rel="nofollow" shape="rect" href="http://www.kitware.com/" target="_blank">www.kitware.com</a><br clear="none">
<br clear="none">
Visit other Kitware open-source projects at <a rel="nofollow" shape="rect" href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensou rce/opensource.html</a><br clear="none">
<br clear="none">
Search the list archives at: <a rel="nofollow" shape="rect" href="http://markmail.org/search/?q=vtk-developers" target="_blank">http://markmail.org/search/?q= vtk-developers</a><br clear="none">
<br clear="none">
Follow this link to subscribe/unsubscribe:<br clear="none">
<a rel="nofollow" shape="rect" href="http://public.kitware.com/mailman/listinfo/vtk-developers" target="_blank">http://public.kitware.com/mail man/listinfo/vtk-developers</a><span class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345m_8577259833820698672HOEnZb"><font color="#888888"><br clear="none"></font></span></blockquote></div><span class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345m_8577259833820698672HOEnZb"><font color="#888888"><br clear="none"><br clear="all"></font></span><div><br clear="none"></div>-- <br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345m_8577259833820698672m_-2281178649223897747gmail_signature">______________________________ _____________<br clear="none">Andrew J. P. Maclean<br clear="none"><br clear="none">______________________________ _____________</div>
</div></div></div>
</blockquote></div><br clear="none"><br clear="all"><div><br clear="none"></div>-- <br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345m_8577259833820698672gmail_signature">______________________________ _____________<br clear="none">Andrew J. P. Maclean<br clear="none"><br clear="none">______________________________ _____________</div>
</div>
</div></div></blockquote></div></div><br clear="none"><br clear="all"><div><br clear="none"></div>-- <br clear="none"><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yiv3645097601m_7023432184253920345gmail_signature">______________________________ _____________<br clear="none">Andrew J. P. Maclean<br clear="none"><br clear="none">______________________________ _____________</div>
</div></div></div></div><br><div class="m_592371077273407711m_-7130409185544451111m_8632643499266567075yqt4739705124" id="m_592371077273407711m_-7130409185544451111m_8632643499266567075yqt40557">______________________________<wbr>_________________<br clear="none">Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br clear="none"><br clear="none">Visit other Kitware open-source projects at <a shape="rect" href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br clear="none"><br clear="none">Search the list archives at: <a shape="rect" href="http://markmail.org/search/?q=vtk-developers" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br clear="none"><br clear="none">Follow this link to subscribe/unsubscribe:<br clear="none"><a shape="rect" href="http://public.kitware.com/mailman/listinfo/vtk-developers" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/vtk-developers</a><br clear="none"><br clear="none"></div><br><br></div><span class="m_592371077273407711HOEnZb"><font color="#888888"> </font></span></blockquote><span class="m_592371077273407711HOEnZb"><font color="#888888"> </font></span></div><span class="m_592371077273407711HOEnZb"><font color="#888888"> </font></span></div><span class="m_592371077273407711HOEnZb"><font color="#888888"> </font></span></div></div></div></blockquote></div><span class="m_592371077273407711HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_592371077273407711m_-7130409185544451111gmail_signature" data-smartmail="gmail_signature">______________________________<wbr>_____________<br>Andrew J. P. Maclean<br><br>______________________________<wbr>_____________</div>
</font></span></div></div>
<br>______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div></div>