[vtk-developers] Various issues on my dashboards... help needed...

[David Cole]

In this thread :
http://public.kitware.com/pipermail/vtk-developers/2017-August/035314.html
, Ken Martin said

"the llvm folks added this due to some ODR violation checking.
That having it unused can cause it to be defined multiple times in a
translation unit for some reason."

Despite my Google skillz, I could not find what exactly he was
referring to, and a search on the quoted "-Wunused-template" doesn't
help much. Or I didn't dig deep enough.

Anyhow:

I think you should favor limiting the disabled bit of the warning to
the scope where you know it's safe to ignore, and not just put a
blanket suppression on it. Each warning is useful to somebody for some
code, and ignoring them everywhere by a global compile flag is not the
best way to suppress a warning in a handful of files among thousands.


Just my opinion ... but there you have it.

David C.





On Wed, Aug 16, 2017 at 7:06 PM, Sean McBride <sean at rogue-research.com> wrote:
> On Wed, 16 Aug 2017 13:54:26 -0400, Allie Vacanti said:
>
>>> Allison, do you think you can work on the data array warnings?
>>>
>>> I think if both Allison and I take care of those it should whittle down the
>>> list to a more manageable size to start getting others to help out with.
>>
>>I think we should just disable the unused-template warnings. Most of
>>these cases depend on the ArrayDispatch configuration and can't be
>>removed without breaking features, even though some builds don't use
>>them.
>
> Allie,
>
> OK, so we just have to decide if we should:
>  a) use "#pragma clang diagnostic ignored" to disable this warning for the ArrayDispatch file(s)
> or
>  b) I just add -Wno-unused-template to disable it everywhere and always
>
> I guess it depends if the warning is generally useful (except for the funky case of ArrayDispatch stuff), or generally useless.
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>