[vtk-developers] vtkDataSetGeometryFilter and error reporting

[Will Schroeder]

I think there are cases, especially in parallel computing, where the input
may consist of 0 cells. In which case it is not an error and should proceed
silently. I suppose a debug macro might be helpful.

Best,
W

On Mon, May 16, 2016 at 3:50 PM, Bill Lorensen <bill.lorensen at gmail.com>
wrote:

> Folks,
>
> I am writing a unit test for DataSetGeometryFilter. During this
> adventure, I noticed that the filter silently ignores the case when
> the input dataset has 0 cells. I added error macros for those cases.
>
> In the cdash build for my merge request I see 8 failing tests:
> https://open.cdash.org/viewTest.php?onlyfailed&buildid=4368497
>
> How to handle this?
> 1) Do not report the error and silently ignore it. This is the current
> approach.
> 2) Issue a warning. A possible compromise.
> 3) Issue an error.
>
> For 3) I will need to look at each test and see why the number of
> cells provided is 0. I don't mind doing this, I might discover other
> erros in the orther tests.
>
> Comments please,
>
> Bill
>
> BTW, my unit test covers over 90% of the code now.
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>


-- 
William J. Schroeder, PhD
Kitware, Inc. - Building the World's Technical Computing Software
28 Corporate Drive
Clifton Park, NY 12065
will.schroeder at kitware.com
http://www.kitware.com
(518) 881-4902
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20160516/fe817156/attachment.html>